flowershow icon indicating copy to clipboard operation
flowershow copied to clipboard

Published 20 hours ago • verified publisher icon datopian

Adjust code blocks style to light theme

Open olayway opened this issue 3 years ago • 8 comments

This doesn't look good:

image

Acceptance

  • [ ] code blocks styling adjusted to match the rest of the light theme

olayway avatar Oct 07 '22 11:10 olayway

heyy @olayway can i work on this issue ?

bilalshaikh292 avatar Oct 09 '22 07:10 bilalshaikh292

Hi, @bilalshaikh292! Sure, go ahead!

olayway avatar Oct 10 '22 06:10 olayway

so @olayway can your please guide me some help ?

bilalshaikh292 avatar Oct 18 '22 06:10 bilalshaikh292

hey ,@olayway I am working on this issue.Can you tell which color should I use?Is it white background or some other color to match the rest of the light theme?

bilalshaikh292 avatar Nov 09 '22 19:11 bilalshaikh292

Hi @bilalshaikh292! Sorry for not replying to your earlier comment! I think white background will be good. And please do let me know if you have any other questions. Thank you for your willingness to work on that! 😊🌼

olayway avatar Nov 10 '22 12:11 olayway

heyy @olayway do we have to make the new theme like this.this is full white.do we have to white back ground or opaque?

bilalshaikh292 avatar Nov 12 '22 18:11 bilalshaikh292

sample 1

bilalshaikh292 avatar Nov 12 '22 18:11 bilalshaikh292

@bilalshaikh292 it should basically render with an appropriate color e.g. on the dark them what color does code block render as (is it the same color i.e. transparent against background or ...)

rufuspollock avatar Nov 12 '22 22:11 rufuspollock

Related to Flowershow Self-Hosted which has been deprecated. WONTFIX

olayway avatar May 20 '25 09:05 olayway