datapusher-plus icon indicating copy to clipboard operation
datapusher-plus copied to clipboard

CKAN__DATAPUSHER__CALLBACK_URL_BASE ignored for data fetch

Open jhbruhn opened this issue 2 years ago • 2 comments

I am using ckan behind a proxy which uses another internal authentication. Datapusher Plus (on the fixing-issues) branch is mostly aware of the CKAN__DATAPUSHER__CALLBACK_URL_BASE, but seems to be missing the DATAPUSHER_REWRITE_RESOURCES parameter present in the original datapusher implementation. This leads to an error while fetching data from the CKAN instance, while ironically the worker is on the same host/container in my case.

https://github.com/dathere/datapusher-plus/blob/d28570ff295841b5c1392cb805eca8c8791b97f7/ckanext/datapusher_plus/logic/action.py#L173

jhbruhn avatar Mar 28 '24 16:03 jhbruhn

The actual location where the URL should be rewritten is here: https://github.com/dathere/datapusher-plus/blob/d28570ff295841b5c1392cb805eca8c8791b97f7/ckanext/datapusher_plus/jobs.py#L430

jhbruhn avatar Mar 28 '24 16:03 jhbruhn

@jhbruhn thanks agian for your findings

Feel free to provide PR's for any issue that you could find

tino097 avatar Mar 28 '24 21:03 tino097