website icon indicating copy to clipboard operation
website copied to clipboard

Cleanup from new UX

Open baltpeter opened this issue 3 years ago • 23 comments

In the interest of moving forward, we'll soon merge website#895 into new_ux.

But the following still needs to be addressed before new_ux can be merged into master:

  • [x] CompanySearchPage needs to respect the privacy controls. @baltpeter
  • [ ] Functional "Export to calendar" button on "What's next" page.
  • [x] Added fill fields shouldn't be marked as required. @zner0L
  • [x] Fix "[object Object]" at the top of the "copy manually" text of PDF requests.
  • [x] Support other languages than EN in app.
  • [x] User cannot mark manually copied request as sent. @zner0L
  • [x] In the arrow thing at the top, long company names should be elided instead of spanning multiple rows. @zner0L
  • [x] The "add input" dropup is cut off if it has too many elements. @zner0L
  • [ ] Enable noUncheckedIndexedAccess in tsconfig.json.
  • [x] Checkbox for tracking requests.
  • [ ] Write many, many tests.
    • [x] From wizard-regressions:
      • Ensure that we actually go through all added companies.
      • Ensure that done companies are correctly reflected in the "breadcrumbs".
    • [ ] From wizard:
      • Ensure translation macros work.
    • [x] From country-change-updates-wizard:
      • Ensure changing the country changes the company packs.
    • [x] Test parameters in old and new generator
  • [x] Support old URLs in new generator.
  • [x] Mention old generator in new generator if user has an existing request from before today.
  • [x] Link old generator in the footer.
  • [x] Mention new generator in the old one.
  • [x] Get rid of the "wizard" and react-joyride @baltpeter
  • [x] Pretty new homepage.
  • [ ] Handle browser back/forward navigation.
  • [ ] Global settings page with settings for:
    • Transport medium (use suggested (default) or always override with x)
    • "Request machine-readable data in access requests" (defaults to true)
  • [ ] Collapse MailtoDropdown to mere mailto: link on mobile.
  • [ ] Persist the state.
  • [ ] Proper "What's next" page.
  • [ ] Improve the "Your GDPR rights" blog post.
  • [ ] I know I've said it before but I don't think the blue background is an intuitive way to indicate a selected state. This seems more like a hovered/focussed state. This is especially true if there is only one result (e.g. if you search for "google").
  • [x] #935
  • [x] If we do: Proper meta data for app page.
  • [x] Flow for requesting companies not in the database!
  • [x] Do we need to call renderLetter()?
  • [x] Write an introductory text for the RequestTypeChooserPage.

baltpeter avatar Jul 14 '22 10:07 baltpeter

We'll also need to address the user testing feedback:

  • [x] https://github.com/datenanfragen/website/pull/895#issuecomment-1177486267

baltpeter avatar Jul 14 '22 10:07 baltpeter

  • [x] The focus should be reset to the company chooser modal in the company packs (otherwise you need to tab through the whole page) @zner0L
  • [x] Which reminds me: Our modals are not a11y-friendly, yet. @zner0L
  • [x] Ability to mark requests as send if you just copied the text (maybe a keyboard listener?) @zner0L
  • [x] Fix jumping buttons in the company modal @zner0L
  • [x] Fix non-focusable MailtoDropdown options @zner0L
  • [ ] I think we need to indicate somehow if (some of) a company pack was added. Currently, the user can not be sure just from the company packs UI.

zner0L avatar Jul 15 '22 10:07 zner0L

  • [ ] Test our amazing new localforage replacement (see #916)

zner0L avatar Aug 01 '22 17:08 zner0L

  • [x] Get rid of setCustomLetterTemplate

zner0L avatar Aug 01 '22 17:08 zner0L

  • [ ] Pagination in proceedings list

zner0L avatar Aug 02 '22 15:08 zner0L

  • [ ] Delete blobs from deleted messages (in the app-apps).
  • [x] Properly fix idb bug: "Uncaught DOMException: The operation failed because the stored database is a higher version than the version requested."

baltpeter avatar Aug 30 '22 22:08 baltpeter

  • [x] ID data explanation text isn't correct for tracking requests.

baltpeter avatar Sep 28 '22 18:09 baltpeter

  • [x] Duplicate ids if there is more than one DynamicInputContainer on a page @baltpeter: https://github.com/datenanfragen/website/blob/623b22dff11998a47749e0f239a21b6a60437200/src/Components/Generator/DynamicInputContainer.tsx#L156

baltpeter avatar Oct 11 '22 14:10 baltpeter

  • [x] https://github.com/datenanfragen/website/blob/f07d36385fb8fd1a1d8b3969528504c46baa7a52/src/Components/RequestList.tsx#L406-L407

baltpeter avatar Oct 15 '22 08:10 baltpeter

  • [x] https://github.com/datenanfragen/website/blob/f07d36385fb8fd1a1d8b3969528504c46baa7a52/src/Components/RequestList.tsx#L364

Also: I am always setting the content in Reactor, whereas the generator doesn't do that. Do we want to keep doing that?

baltpeter avatar Oct 17 '22 12:10 baltpeter

  • [x] SvaFinder styling is broken again

baltpeter avatar Oct 19 '22 09:10 baltpeter

  • [x] https://github.com/datenanfragen/letter-generator/issues/12

baltpeter avatar Oct 26 '22 15:10 baltpeter

  • [x] commons.bundle.gen.js is huge (1.35 MiB), also app.bundle.gen.js is 290 KiB, which isn't ideal (moved to #957)

baltpeter avatar Oct 26 '22 16:10 baltpeter

  • [x] Transparency details

baltpeter avatar Oct 28 '22 15:10 baltpeter

  • [ ] Blog post about the launch

baltpeter avatar Oct 31 '22 16:10 baltpeter

  • [x] Button to "reactivate" done requests

zner0L avatar Nov 04 '22 22:11 zner0L

  • [x] Fix padding in multi-line buttons.

image

baltpeter avatar Nov 29 '22 20:11 baltpeter

  • [x] The "generate admonition/complaint based on your answers" button after entering some issues in reactor should be highlighted (thanks, @mal-tee).

baltpeter avatar Dec 01 '22 11:12 baltpeter

  • [x] The radio buttons don't have a focused state. :o

baltpeter avatar Dec 01 '22 12:12 baltpeter

  • [x] Update hint request cut-off date.

baltpeter avatar Dec 04 '22 13:12 baltpeter

  • [ ] Integrate https://github.com/datenanfragen/letter-generator/pull/17.

baltpeter avatar Dec 05 '22 17:12 baltpeter

  • [ ] #982
  • [x] #981

mal-tee avatar Dec 09 '22 12:12 mal-tee

I took the liberty of renaming this, since we merged. :partying_face: Might be easier for our users to find known-bugs this way.

mal-tee avatar Dec 09 '22 12:12 mal-tee