website
website copied to clipboard
datenanfragen
Changing page language shows modal in current language
i.e if on the german website and I try to change the language, I will be shown a modal in German warning me
.
I think it would be more expected to have both target selected language appear, and current page language. Perhaps the buttons should be in the target language?
Hi @TomerPacific, I've been working on some changes to this I18NWidget and suggesting other languages on the PR #615. This PR has now changed the behaviour, to where the target language is shown in the modal (instead of the current language). If you wanted to help out, you could try and figure out how to display both current and target language? Maybe with a HR element between them?
@davenewham , I've looked over the PR. Would it be best that I branch out of the PR's branch and opened a new PR for that?
The PR is now merged, so you can also work straight from master if you haven't started already. :)
@baltpeter, should I open a new issue then or would you like to keep this one open?
@TomerPacific I see no reason to open a new issue, let's use this one. I can assign you if you want.
@baltpeter, sure let's do that. Just wanted to make sure I am aligned with your working style.
@baltpeter, just to make sure I understand what needs to be done, you would like to display in the modal, the current language of the website and also the target language selected?
If this is so, would you like that the different versions of the text appear inside the buttons or somewhere else? I.E. at the top of the modal?
just to make sure I understand what needs to be done, you would like to display in the modal, the current language of the website and also the target language selected?
Yes, exactly. Otherwise, a user who accidentally selects the wrong language might not find their way back.
If this is so, would you like that the different versions of the text appear inside the buttons or somewhere else? I.E. at the top of the modal?
Not sure. As @davenewham said, we haven't figured out a design for that yet. That's also part of the scope of this issue.
I think the visible text should be in the language the user is trying to change to, while the text in the language the website is currently in should be hidden in a <detail>. Also, I think the button for "Stay here" should definitely be in the current language.
@baltpeter, just wanted to update that I am having some issues with setting up the local environment. I am working on a Windows machine and am following the development guide. It seems that running the deploy.sh script takes a really long time (it gets stuck on the phase of Renaming JSON Files). Don't know if that is the expected behavior.
As far as I know, it's unfortunately quite common for this to take a while on Windows. We're working on improving that a bit at least in #674. But for Windows-related questions, you should definitely ask @mal-tee. I don't have any experience with that.
@baltpeter - might be worthwhile to assign someone else this issue. I do not know if I will be able to overcome to specific platform issues and I do not want to waste your time.