website icon indicating copy to clipboard operation
website copied to clipboard

Broken external link styling on open source page

Open baltpeter opened this issue 3 years ago • 3 comments

On the open source page, the external link styling is broken in various ways:

image

Not sure what to do here.

The most obvious problems are that the indicator is in the next line for the icons and headings. That's because those are block elements which push their ::after (which is used to insert the indicator) to the next line. You could "solve" the problem by adding the no-link-decoration class to the links but now users wouldn't have any indication that those are external links, which means that isn't an option.
Another option (which I'm not a fan of either but it would be less unacceptable) would be to just remove the links from the images and headings…

Either way, the "View repository" buttons definitely also need external link styling.

baltpeter avatar Sep 13 '21 20:09 baltpeter

Hey! I would like to work on this.

Also, since the view repository already has the link to the repository, we might as well remove the links form image and heading. what do you say?

tiger-yash avatar Oct 05 '21 20:10 tiger-yash

@tiger-yash We should keep the link on the heading. While I would prefer to also keep the link on the image, I'm ok with removing that as I can't think of a solution to indicate that this is an external link.

baltpeter avatar Oct 06 '21 10:10 baltpeter

Thanks for the designs, @tiger-yash! I prefer the upper one.

baltpeter avatar Oct 07 '21 09:10 baltpeter