website icon indicating copy to clipboard operation
website copied to clipboard

Generator crash with invalid parameter (unusable report window)

Open mal-tee opened this issue 5 years ago • 5 comments

  • visit https://www.datenanfragen.de/generator#!company=datenanfragen,facebook

mal-tee avatar Nov 08 '20 13:11 mal-tee

I think https://www.datenanfragen.de/generator#!company=invalidcompany is a better example that doesn't suggest that specifying multiple companies for #!company should work. :D

baltpeter avatar Nov 08 '20 13:11 baltpeter

Note: The variant with a comma seems to render two error windows. invalidcompany only one. :D

mal-tee avatar Nov 08 '20 13:11 mal-tee

I think they both produce the two error modals most of the time but datenanfragen,facebook seems more "reliable". :D

baltpeter avatar Nov 08 '20 14:11 baltpeter

datenanfragen, facebook also produces a crash. Understandable, but I would prefer if we could trim the values.

mal-tee avatar Nov 15 '20 13:11 mal-tee

Well, the parameter wasn't really designed to be used manually by humans. :D But sure, we can do that.

baltpeter avatar Nov 15 '20 13:11 baltpeter

Invalid companies now show a flash message instead of breaking the site: https://www.datarequests.org/generator#!company=invalidcompany

And https://www.datarequests.org/generator#!companies=schufa,%20facebook just works. So this fixed.

baltpeter avatar Jun 10 '23 11:06 baltpeter