website icon indicating copy to clipboard operation
website copied to clipboard

Scrolling on the company database is broken for mobile

Open mal-tee opened this issue 5 years ago • 8 comments

If you search for a term on the database, you might not be able to see all results, because you can not scroll. Instead of moving the view, the list of all companies in the background is moved.

In this example you can only see the first three results, instead of all five.

grafik

mal-tee avatar Aug 12 '20 08:08 mal-tee

Hello. Can I take this? Please add more info, the page on which the issue exists.

hadron43 avatar Oct 02 '20 10:10 hadron43

Sure, have at it! You can find the issue here: https://www.datarequests.org/company

Files you might want to look at are layouts/company/list.html and src/company-list.js

zner0L avatar Oct 02 '20 10:10 zner0L

Please assign me.

hadron43 avatar Oct 02 '20 10:10 hadron43

While building, I'm facing the following error. Any suggestions? Start building sites … ERROR 2020/10/02 17:35:56 TOCSS: failed to transform "styles/loader.scss" (text/x-scss): resource "scss/styles/loader.scss_16daf05a51a1b3e21f08cb57cd3d16ce" not found in file cache Built in 4354 ms Error: Error building site: TOCSS: failed to transform "styles/main.scss" (text/x-scss): resource "scss/styles/main.scss_16daf05a51a1b3e21f08cb57cd3d16ce" not found in file cache

hadron43 avatar Oct 02 '20 12:10 hadron43

Make sure you're using the Extended version of Hugo. That should fix the error.

baltpeter avatar Oct 02 '20 12:10 baltpeter

What kind of behavior is expected? Shall I remove the "Our company database holds the contract..." line when the div becomes sticky? But it still won't guarantee proper functioning.

Another option is to reduce the number of search results to 3, which I guess will be complicated to implement.

hadron43 avatar Oct 02 '20 17:10 hadron43

I think there are two things you can do: hide the text and button when scrolling and implement proper overflow handling for the search results. You can also try and limit the amount of search results based on the screen size, but I feel like this could end up being pretty error prone.

zner0L avatar Oct 02 '20 19:10 zner0L

I hope this fixes it. Please review.

hadron43 avatar Oct 03 '20 05:10 hadron43