datenanfragen
Fixes #1211: Build JS with Hugo instead of Webpack
datenanfragen/website
Run #8425
Run Properties:
Failed #8425
95253875bb: Webpack be gone \o/
Failed #8425 95253875bb: Webpack be gone \o/| Project |
datenanfragen/website
|
| Branch Review |
b_hugo-esbuild
|
| Run status |
|
| Run duration | 18m 02s |
| Commit |
|
| Committer | Benjamin Altpeter |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
16
|
Flaky
|
0
|
Pending
|
8
|
Skipped
|
1
|
Passing
|
63
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
company-database/search.spec.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Search for company by slug and visit company detail page > Search for and visit 1&1 single page |
Screenshots
Video
|
|
components/advanced-generator.spec.js • 3 failed tests
components/generator.spec.js • 2 failed tests
| Test | Artifacts | |
|---|---|---|
| Request generator tool component > respects request tracking status |
Screenshots
Video
|
|
| Request generator tool component > can toggle request tracking status |
Screenshots
Video
|
|
components/mailto-dropdown.spec.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| MailtoDropdown > Copying the email elements manually |
Screenshots
Video
|
|
components/proceedings.spec.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Proceedings page > assigns correct state |
Screenshots
Video
|
|
The first 5 failed specs are shown, see all 11 specs in Cypress Cloud.
![cypress[bot] avatar](https://avatars.githubusercontent.com/in/9078?v=4 "Published by a pub.dev verified publisher"){kind=small}
Alright. As far as I can tell, this is now ready for review. A couple of things to note:
-
This should be reviewed very carefully. There is obviously quite a lot of potential for breakage. In addition to that, we also need to be on the look-out for non-obvious gotchas like https://github.com/datenanfragen/website/blob/b_hugo-esbuild/layouts/partials/scripts.html#L10-L11. I would appreciate a review from both of you, @zner0L and @mal-tee.
-
As we discussed in https://github.com/datenanfragen/website/issues/1211#issuecomment-3460951828, I have been ignoring CI failures because of interdependencies between this PR and #1205, where neither can really move forward without the other. The random build failures I've been seeing (both locally and in CI) seem like a Hugo bug (locally, I've been using the latest Hugo version today and not seen it happen anymore so far), but because of our ancient Node version and which Docker images are available for it, we cannot upgrade Hugo yet.
As such, I propose that we merge this PR into the
webpack-node-stagingbranch for the time being. Then @davenewham can rebase #1205 onto that, which should hopefully simplify that PR greatly. We'd then also merge #1205 intowebpack-node-staging. And finally, I would work onwebpack-node-stagingand fix the final remaining issues and create a PR to merge that intomaster. -
Given the previous point, I also haven't fixed all Cypress errors yet. There are a handful when I run the tests locally, but at a glance these all seem like Cypress flake to me. Thus, I don't think it makes sense to work on them before we've updated everything.
We can also bump cypress after the node bump, which will introduce some QoL features iirc :D
