website icon indicating copy to clipboard operation
website copied to clipboard
verified publisher icon datenanfragen

Error-Handler: Ignore errors if the browser is outdated. Fixes #644

Open mal-tee opened this issue 1 year ago • 2 comments

mal-tee avatar Jun 18 '24 18:06 mal-tee

datenanfragen/website    Run #8290

Run Properties:  status check passed Passed #8290  •  git commit 71561ac40b: Don't directly use explanation in innerHTML
Project datenanfragen/website
Branch Review m_deprecated_error
Run status status check passed Passed #8290
Run duration 05m 03s
Commit git commit 71561ac40b: Don't directly use explanation in innerHTML
Committer Benjamin Altpeter
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 8
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 80
View all changes introduced in this branch ↗︎

cypress[bot] avatar Jun 18 '24 18:06 cypress[bot]

Thanks! But my concern is that we should only prevent users with unsupported browsers from reporting errors, not from seeing them. That would only lead to the site being inexplicably broken for them.

My suggestion would be to still show the modal but not the sections for reporting the error but instead display a warning that this is likely caused by an outdated browser.

baltpeter avatar Jun 27 '24 09:06 baltpeter

Thanks! But my concern is that we should only prevent users with unsupported browsers from reporting errors, not from seeing them. That would only lead to the site being inexplicably broken for them.

But we are doing the same with extension users. Should we change the behaviour there as well? But I don't think we really want to support debugging weird extensions..

mal-tee avatar Nov 08 '24 22:11 mal-tee

The extension errors usually are meaningless for us (they only occur in the extensions' content scripts) and don't affect our site which continues to work fine.

That's not the case here, though. If the user's browser doesn't support the functions you check for, features on our site will break. If we don't show any notice to the user, the site will just be inexplicably broken for them. We should tell them that the error was caused by their outdated browser and that they need to switch to a supported browser to use our site.

baltpeter avatar Nov 13 '24 09:11 baltpeter

Do we still want this? I'd like to see this merged, to reduce possible future overhead in our inbox.

mal-tee avatar Oct 09 '25 13:10 mal-tee

I tried to test this using BrowserStack. In Firefox 62 (last version to not have Object.fromEntries), our JS is just completely broken, not even the error handler loads. I didn't even test Firefox 12 (last version not to have Map).

But in Firefox 103 (last version without Array.findLast), the site works and as does this change:

image

baltpeter avatar Oct 10 '25 12:10 baltpeter