datenanfragen
WIP: Introduce "webform" field
This is in preparation for datenanfragen/website#401.
This is one of those cases where I would appreciate a review from both of you (especially for the first commit and whether that's how we want to implement this).
Things I still need to do:
- Write the
schemaissue. - Implement the changes for the SVAs and collect all their web forms.
OK, so I don't really understand what happens with this URI in the UI. Do you only want to show the link and give users the options to switch websites in order to skip our generator? Or do you want to try some CSRF and send requests to that URI. I think we need more information to try the latter…
Pretty much what I said here: https://github.com/datenanfragen/website/issues/401#issuecomment-695180685
I don't think it's (realistically) possible to do anything other than link the form and offer the user to copy the text manually.
But would you set the suggested-transport-medium to webform in this case? And would you then change the required fields such that they match the fields in the form?
I would change the stm, yes. That just isn't implemented yet because it would obviously break website.
As for the req-elems: From experience, a lot of these forms are just contact forms where you can select "privacy request" or something like that as the subject. But if the form asks for specific ID elements (and we consider them reasonable), then yes, I would add them as req-elems.
Great! Now that we have your okay for the schema, I can bring the PR up-to-date and de-WIP it.
I have rebased on master and fixed the conflicts. I still need to make the changes for the newly added webforms.
I'm currently working on moving the web form comments in SVAs to webform and updating the records while I'm at it (quite a few are outdated :/).
Annoyingly, https://www.ldi.nrw.de/ seems to be down right now. -.-
Ok, I've now gone through all SVAs and updated their details (a lot were outdated :/). The LDI NRW website has also come back online.
With that, this is ready for review. But as mentioned in #2099, https://github.com/datenanfragen/website/pull/1022 should be merged first. Please rebase merge instead of squashing.
The AppVeyor test runs against the schema on master, so the fail is expected.