Custom licenseKey.secretName not found

[antonu17]

Problem

Providing custom licenseKey.secretName makes pods unable to start due to secret not found.

How to reproduce

helm repo add edge-stack https://s3.amazonaws.com/datawire-static-files/charts
helm repo update
helm install edge-stack edge-stack/edge-stack --set licenseKey.secretName=license-secret

Reason

Here .Values.licenseKey.secretName is resolved in the context of the subchart (emissary-ingress), where this value doesn't exist.

https://github.com/datawire/edge-stack/blob/16acdfb3b6c107de2b558fd26a27368a9a2d00f6/charts/edge-stack/values.yaml#L52-L59

It is possible to get this deployed correctly if both licenseKey.secretName and emissary-ingress.licenseKey.secretName are set like so:

helm upgrade edge-stack edge-stack/edge-stack --set licenseKey.secretName=license-secret --set emissary-ingress.licenseKey.secretName=license-secret

Possible solution

This can be fixed by moving licenseKey parameter to global: block. This will make it available in both edge-stack and emissary-ingress charts context.