OF-Scraper icon indicating copy to clipboard operation
OF-Scraper copied to clipboard

aiolimiter dropped suport for the compat module, breaking this app

Open perpetuallyhorni opened this issue 1 year ago • 2 comments

Describe the bug

On archlinux, when executing the script, it closes abruptly as the compat module was removed from aiolimiter 2 weeks ago

To Reproduce

Steps to reproduce the behavior:

  1. Install ofscraper via pipx
  2. $ ofscraper
  3. ofscraper will close itself
  4. See error in the log file

Expected behavior

Program works correctly.

Screenshots/Logs

Relevant log

Config

Deleted my config files, so there's nothing deviating from default configs.

System Info

  • OS: arch linux
  • Browser NA
  • Version 3.12.9
  • python
  • installed via pipx

Additional context

compat was removed from aiolimiter v1.1.1 onwards, so using version 1.1.0 works

pipx inject ofscraper aiolimiter==1.1.0 --force

perpetuallyhorni avatar Dec 15 '24 01:12 perpetuallyhorni

To be clear, for any end-users reading this, the error line in the log contains "No module named 'aiolimiter.compat'" and the workaround/fix is to run pipx inject ofscraper aiolimiter==1.1.0 --force

perpetuallyhorni avatar Dec 15 '24 01:12 perpetuallyhorni

Worked perfectly on a fresh install of ofscraper on a brand new Macbook. I tried several different ways to install aiolimiter thinking that was the problem before finding out compat had been removed in 1.1.1.

Cheers

cornerdebug avatar Dec 31 '24 03:12 cornerdebug

I made changes to aiolimiter to simplify it use

This should be fixed

datawhores avatar May 30 '25 14:05 datawhores