datasophon icon indicating copy to clipboard operation
datasophon copied to clipboard

[Improvement][api] grafana security upgrade

Open 88fantasy opened this issue 1 year ago • 3 comments

Search before asking

  • [X] I had searched in the issues and found no similar feature requirement.

Description

当前监控的仪表板是直接通过 iframe 嵌入grafana的分享页面

如果直接复制 iframe 也是能打开的, 存在安全问题

应该后端权限校验, 再代理到grafana

Are you willing to submit a PR?

  • [X] Yes I am willing to submit a PR!

Code of Conduct

88fantasy avatar Aug 14 '23 02:08 88fantasy

Search before asking

  • [X] I had searched in the issues and found no similar feature requirement.

Description

The currently monitored dashboard is directly embedded in the shared page of grafana through iframe

If you copy the iframe directly, it can also be opened, and there is a security problem

It should check the back-end permissions, and then proxy to grafana

Are you willing to submit a PR?

  • [X] Yes I am willing to submit a PR!

Code of Conduct

github-actions[bot] avatar Aug 14 '23 02:08 github-actions[bot]

What security issues exist and what impact will it have? Can you tell us?

datasophon avatar Aug 14 '23 03:08 datasophon

要求 最小化端口使用, 且前端应用必须经过帐号密码校验

88fantasy avatar Aug 14 '23 08:08 88fantasy