metric-collector-for-apache-cassandra icon indicating copy to clipboard operation
metric-collector-for-apache-cassandra copied to clipboard

Published 20 hours ago • verified publisher icon datastax

Follow Jsonnet monitoring-mixin structure

Open maxbrunet opened this issue 3 years ago • 3 comments

The diff is fairly large in the Jsonnet files due to changes in indentation, I have also run jsonnetfmt on them, but there are no changes in the generated dashboards at this point.

Currently make-dashboards.sh still uses the Jsonnet library baked into the datastax/grafonnet-lib:v0.1.3 image, but I have locked the Jsonnet library with jb to what I think is the same as the image. So the result should be the same with or without the image, libraries can be upgraded later on if desired.

If this PR is accepted, I will propose Prometheus rules in another PR.

Closes #69

maxbrunet avatar Apr 07 '22 23:04 maxbrunet

Would those rules be related to the sample in #47?

bradfordcp avatar Apr 08 '22 01:04 bradfordcp

Yes, I think so, the issue also mentions filters, but I would only cover Prometheus alerts/rules

maxbrunet avatar Apr 08 '22 01:04 maxbrunet

Hello @bradfordcp, would you have time to give this PR a review, please?

If you are looking for a baseline, Prometheus and Thanos are sort of the references in term of mixins: https://github.com/prometheus/prometheus/tree/main/documentation/prometheus-mixin https://github.com/thanos-io/thanos/tree/main/mixin

More at https://monitoring.mixins.dev/

Please do not hesitate to let me know if you have any questions

maxbrunet avatar Apr 14 '22 16:04 maxbrunet