kaap icon indicating copy to clipboard operation
kaap copied to clipboard

migration tool should only put non-default values in the generated values file

Open pgier opened this issue 2 years ago • 2 comments

To keep the generated values more concise and allow for easier review, the migration tool should only print values which override the defaults.

An alternative might be a tool to remove all default values from an existing values file. Then you could take the output of the current migration tool and run it through the cleanup/minimize tool.

pgier avatar Jul 31 '23 19:07 pgier

This is already done partially. Could you list which values did you see ?

nicoloboschi avatar Aug 14 '23 15:08 nicoloboschi

Looking at the generated values.yaml file, there are lots of values included which match the default settings. Here are a few examples:

kaap:
  cluster:
    spec:
      global:
        dnsConfig:
          options:
          - name: ndots
            value: '4'
        kubernetesClusterDomain: cluster.local
        tls:
          brokerResourceSets: {
            }
          proxyResourceSets: {
            }
      zookeeper:
        nodeSelectors: {
          }
        tolerations: [
          ]

pgier avatar Aug 16 '23 16:08 pgier