cassandra icon indicating copy to clipboard operation
cassandra copied to clipboard

CNDB-9707 Implement RequestSensorsFactory to control sensors tracking per keyspace

Open aymkhalil opened this issue 1 year ago • 2 comments

Addresses: https://github.com/riptano/cndb/issues/9707

Adds RequestSensorsFactory that can be provided from upstream dependents to effectively enable/disable sensors tracking per ks

aymkhalil avatar Jun 10 '24 23:06 aymkhalil

This looks ok to me conceptually. Is this ready for a review?

Let me do the changes on CNDB side and then mark it as ready for review - but I thought I'd share a draft version for early feedback on the direction

aymkhalil avatar Jun 11 '24 15:06 aymkhalil

@niksajakovljevic This is ready for review: the first commit has been rebased to the latest main-ucu, the second commit is some new stuff needed by CNDB.

sbtourist avatar Aug 02 '24 13:08 sbtourist

we should properly mark constructors for testing

Done it based on your previous comments but forgot to push :man_facepalming:, here you are: https://github.com/datastax/cassandra/pull/1148/commits/d4b6a3d3f255f87aa02f197e45de484086934b35

sbtourist avatar Aug 12 '24 09:08 sbtourist