Column 3 has bad format

[roll]

$ goodtables datapackage http://data.okfn.org/data/core/gdp/datapackage.json
DATASET
=======
{'error-count': 999, 'table-count': 1, 'time': 2.588, 'valid': False}

TABLE [1]
=========
{'datapackage': 'http://data.okfn.org/data/core/gdp/datapackage.json',
 'error-count': 999,
 'headers': ['Country Name', 'Country Code', 'Year', 'Value'],
 'row-count': 1000,
 'source': 'https://raw.githubusercontent.com/datasets/gdp/master/data/gdp.csv',
 'time': 1.948,
 'valid': False}
---------
[2,3] [non-castable-value] Row 2 has non castable value in column 3 (type: date, format: yyyy)
[3,3] [non-castable-value] Row 3 has non castable value in column 3 (type: date, format: yyyy)
...

from https://github.com/frictionlessdata/jsontableschema-py/issues/145

[rufuspollock]

@roll that is not a super informative output ;-) - what exactly is wrong with row 2? yyyy should count as a valid date no and the data looks ok:

https://github.com/datasets/gdp/blob/master/data/gdp.csv#L3

[roll]

@rufuspollock I suppose this format string is just against the prev stable spec (yyyy => fmt:%y): http://specs.frictionlessdata.io/json-table-schema/#date

It looks like the same issue https://github.com/datasets/gdp/issues/5 (cc @Fak3)

[Fak3]

Yes. Looking at the spec, the correct type of the column should be 'gyear' http://specs.frictionlessdata.io/json-table-schema/#gyear or 'date' with '%Y' format

[rufuspollock]

@Fak3 but that type change is very recent. I guess we should change to gyear ... - will that work @roll?

[roll]

@rufuspollock gyear is not supported yet. Also wasn't there a plan to rename it to year? (we have many moving parts for now..)