Added table schema to Get-DbaDbForeignKey

[pollusb]

Type of Change

• [ ] Bug fix (non-breaking change, fixes # )
• [ ] New feature (non-breaking change, adds functionality, fixes # )
• [ ] Breaking change (affects multiple commands or functionality, fixes # )
• [ ] Ran manual Pester test and has passed (Invoke-ManualPester)
• [ ] Adding code coverage to existing functionality
• [ ] Pester test is included
• [ ] If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
• [ ] Unit test is included
• [ ] Documentation
• [ ] Build system

Purpose

Added table schema to Get-DbaDbForeignKey because it's missing

Approach

Commands to test

Screenshots

Learning

[pollusb]

Can someone help me with this? What do I now?

[andreasjordan]

AppVayor says:

Describe : Get-DbaDbForeignKey Integration Tests
Context  : Parameters are returned correctly
Name     : It Has the correct default properties
Result   : Failed
Message  : Expected @('ComputerName', 'CreateDate', 'Database', 'DateLastModified', 'ID', 'InstanceName', 'IsChecked', 'IsEnabled', 'Name', 'NotForReplication'), but got @('ComputerName', 'CreateDate', 'Database', 
           'DateLastModified', 'ID', 'InstanceName', 'IsChecked', 'IsEnabled', 'Name', 'NotForReplication').
Describe : Get-DbaDbForeignKey Integration Tests
Context  : Parameters are returned correctly
Name     : It Has the correct properties
Result   : Failed
Message  : Expected @('Columns', 'ComputerName', 'CreateDate', 'Database', 'DatabaseEngineEdition', 'DatabaseEngineType', 'DateLastModified', 'DeleteAction', 'ExecutionManager', 'ExtendedProperties'), but got @('Columns', 
           'ComputerName', 'CreateDate', 'Database', 'DatabaseEngineEdition', 'DatabaseEngineType', 'DateLastModified', 'DeleteAction', 'ExecutionManager', 'ExtendedProperties').

[andreasjordan]

The output of the test does not look correct, but as you have added a new property, you have to add it also in lines 56 and 60 of Get-DbaDbForeignKeys.Tests.ps1.

[pollusb]

Many thanks to you. I hope to contribute more. 😁

[pollusb]

Do I need to do anything when "Merging is blocked" ? You're not authorized to push to this branch

[andreasjordan]

No, there is nothing you can do.

Next step is a second review by one of the core contributors who can merge to the development branch (@potatoqualitee / @jpomfret). They will then merge your changes and later publish a new release.

[jpomfret]

Thank you @pollusb for your contribution! (and thank you @andreasjordan as always!)