dbatools icon indicating copy to clipboard operation
dbatools copied to clipboard

New Support for Contained Availability Groups

Open serenefiresiren opened this issue 1 year ago • 3 comments

Type of Change

  • [ ] Bug fix (non-breaking change, fixes # )
  • [x] New feature (non-breaking change, adds functionality, fixes #8713 )
  • [ ] Breaking change (affects multiple commands or functionality, fixes # )
  • [ ] Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
  • [ ] Adding code coverage to existing functionality
  • [ ] Pester test is included
  • [ ] If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
  • [ ] Unit test is included
  • [ ] Documentation
  • [ ] Build system

Purpose

SQL Server 2022 added support for contained availability groups.

Approach

The New-DbaAvailabilityGroup leverages the built-in ReuseSystemDatabses and IsContained parameters to facilitate both the initial build and a recreation with previously provisioned contained databases.

Commands to test

Work in progress

Learning

What is a contained availability group? New-SQLAvailabilityGroup SMOObject

serenefiresiren avatar May 11 '24 18:05 serenefiresiren

Thanks for the feedback! I'll get these fixed Monday.

serenefiresiren avatar May 12 '24 11:05 serenefiresiren

Thank you both 🙏🏼 Will fix encoding issue once changes are complete, just prior to merge.

potatoqualitee avatar May 14 '24 08:05 potatoqualitee

https://github.com/serenefiresiren/dbatools/pull/2

DorBreger avatar May 14 '24 11:05 DorBreger

Sorry, still not correct. Please have a look at the other parameter tests.

andreasjordan avatar May 15 '24 16:05 andreasjordan

#9352 has all the needed changes, so we should close this one.

andreasjordan avatar May 15 '24 18:05 andreasjordan

thank you all 🙏🏼 will merge for credit and fix all issues in next PR

potatoqualitee avatar May 16 '24 13:05 potatoqualitee