dbatools icon indicating copy to clipboard operation
dbatools copied to clipboard

Restore-DbaDatabase - improve warning output for standby mode databases

Open 0x7FFFFFFFFFFFFFFF opened this issue 1 year ago • 2 comments

Updated the recovery logic to include databases in standby mode. Previously, the code only addressed databases in the restoring state, which did not account for standby scenarios. This change ensures a more comprehensive recovery process.

Please read -- recent changes to our repo

On November 10, 2022, we removed some bloat from our repository (for the second and final time). This change requires that all contributors reclone or refork their repo.

PRs from repos that have not been recently reforked or recloned will be closed and @potatoqualitee will cherry-pick your commits and open a new PR with your changes.

  • [v] Please confirm you have the smaller repo (85MB .git directory vs 275MB or 110MB or 185MB .git directory)

Type of Change

  • [x] Bug fix (non-breaking change, fixes # )
  • [ ] New feature (non-breaking change, adds functionality, fixes # )
  • [ ] Breaking change (affects multiple commands or functionality, fixes # )
  • [ ] Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
  • [ ] Adding code coverage to existing functionality
  • [ ] Pester test is included
  • [ ] If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
  • [ ] Unit test is included
  • [ ] Documentation
  • [ ] Build system

0x7FFFFFFFFFFFFFFF avatar Jan 29 '24 07:01 0x7FFFFFFFFFFFFFFF

This is marked as being a bug fix, what bug issue is being addressed 😉 ?

wsmelton avatar Feb 01 '24 14:02 wsmelton

This is marked as being a bug fix, what bug issue is being addressed 😉 ?

There doesn't appear to be a related issue; however, it's unable to recover standby database.

0x7FFFFFFFFFFFFFFF avatar Feb 02 '24 08:02 0x7FFFFFFFFFFFFFFF

@wsmelton - do you want an issue created to track this bug fix? or we good to merge?

jpomfret avatar Feb 21 '24 11:02 jpomfret

Merging due to Niph's approval since it's been a while.

potatoqualitee avatar Mar 07 '24 14:03 potatoqualitee