dbatools icon indicating copy to clipboard operation
dbatools copied to clipboard

Update logging framework based on new version of PSFramework

Open andreasjordan opened this issue 2 years ago • 8 comments

Summarize Functionality

See: https://twitter.com/FredWeinmann/status/1533198245496758274

Yo fellows, the latest version of the #psframework #powershell module shipped today! Massively improved logging performance for the logfile provider (and no more collision with your AV), new command to clear in-memory log and (thanks @adamdriscoll !) fixed a memory leak.

Is there a command that is similiar or close to what you are looking for?

No

Technical Details

No response

andreasjordan avatar Jun 05 '22 12:06 andreasjordan

@FriedrichWeinmann probably has a good idea on this but from what I can tell, it looks like dbatools doesn't have the same problem that PSFramework had in terms of the memory leak. I can't speak to the logging performance.

adamdriscoll avatar Jun 07 '22 21:06 adamdriscoll

Indeed, for dbatools, this is not a memory leak issue, however the throughput improvements remain real

FriedrichWeinmann avatar Jun 07 '22 22:06 FriedrichWeinmann

Do you have time to work on this?

andreasjordan avatar Jun 10 '23 16:06 andreasjordan

What needs to be fixed? We have no memory leak on our logging mechanism.

The logging system we have is the beginnings of what PSFramework became and at this point we are so far behind where that module has gone it is unrealistic to think Fred will have time for porting that over. It would be more efficient to swap our logging to depend on PSFramework...but that is not something I would agree with incorporating in the module.

In the area of performance if you want the module to perform better the best option is disabling our logging system itself. You should do that for any automation process, logging is for when you are debugging or troubleshooting.

wsmelton avatar Jun 10 '23 16:06 wsmelton

Thanks for the feedback, will close this now.

andreasjordan avatar Jun 11 '23 12:06 andreasjordan

I think it's a fair question to ask if the fix is quick. Any perf improvements are welcomed

potatoqualitee avatar Jun 11 '23 13:06 potatoqualitee

I've added it for my vacation coding list (calendar blocker and everything so I don't forget; August). Will do the upgrade - the overall effort should be doable.

FriedrichWeinmann avatar Jun 11 '23 14:06 FriedrichWeinmann

Hi @FriedrichWeinmann - is this still on your to do list?

andreasjordan avatar Mar 31 '24 13:03 andreasjordan