dbatools icon indicating copy to clipboard operation
dbatools copied to clipboard
verified publisher icon dataplat

Start-DbaMigration - Add -SetSourceOffline to set databases offline during migration

Open potatoqualitee opened this issue 5 months ago • 6 comments

Enhances the -SetSourceOffline parameter to work like -SetSourceReadOnly, setting databases offline BEFORE migration begins (not after) to prevent any connections to source databases during the migration process.

Closes #9156

Generated with Claude Code

potatoqualitee avatar Nov 29 '25 18:11 potatoqualitee

@claude add an integration test

potatoqualitee avatar Nov 30 '25 00:11 potatoqualitee

Claude finished @potatoqualitee's task —— View job

Integration test added for -SetSourceOffline

  • [x] Read the modified command files to understand the new parameter
  • [x] Read the existing test file to understand test structure
  • [x] Add integration test for -SetSourceOffline parameter
  • [x] Commit and push changes

Summary of changes: The PR modifies -SetSourceOffline to work like -SetSourceReadOnly - setting databases offline BEFORE migration (not after) to prevent connections during migration. When combined with -Reattach, databases are brought back online after being reattached to the source.

Test added: Added a new context "When using SetSourceOffline parameter" that verifies:

  • Source database is set offline before migration
  • Migration completes successfully
  • Destination database is brought online
  • Source database remains offline after migration

The test creates a dedicated test database, migrates it with -SetSourceOffline, and verifies the expected behavior at each step.

| Branch: claude/issue-9156-20251128-1729

claude[bot] avatar Nov 30 '25 00:11 claude[bot]

@claude hullo pls fix the test failures

Path : Start-DbaMigration/When using SetSourceOffline parameter/Should set source database offline before migration and bring destination online Name : It Should set source database offline before migration and bring destination online Result : Failed Message : ErrorRecord: A parameter cannot be found that matches parameter name 'Database'. This error might have been caused by applying the default parameter binding. You can disable the default parameter binding in $PSDefaultParameterValues by setting $PSDefaultParameterValues["Disabled"] to be $true, and then trying again. The following default parameters were successfully bound for this cmdlet when the error occurred: -Confirm -WarningVariable StackTrace : RawErrorRecord : A parameter cannot be found that matches parameter name 'Database'. This error might have been caused by applying the default parameter binding. You can disable the default parameter binding in $PSDefaultParameterValues by setting $PSDefaultParameterValues["Disabled"] to be $true, and then trying again. The following default parameters were successfully bound for this cmdlet when the error occurred: -Confirm -WarningVariable Uploading artifact DetailedTestFailures_Pester5.json (1,813 bytes)...100%

potatoqualitee avatar Nov 30 '25 18:11 potatoqualitee

Claude finished @potatoqualitee's task —— View job

Test failure fixed

  • [x] Read the failing test to understand the error
  • [x] Read Start-DbaMigration.ps1 to understand correct parameter usage
  • [x] Fix the test to use correct parameters
  • [x] Commit and push the fix

Issue found: The test was using -Database parameter which doesn't exist on Start-DbaMigration. The command migrates all databases and doesn't support filtering to specific databases (only -Exclude for exclusions).

Fix applied:

  • Removed the invalid -Database $offlineTestDb parameter from the test
  • Added proper -Exclude parameter to skip non-database migration objects (same pattern as other tests in the file)
  • Added verification that the test database was included in the migration results
  • Test now migrates all databases and then verifies the specific test database was handled correctly with the -SetSourceOffline behavior

The test will now properly validate that -SetSourceOffline sets databases offline before migration and leaves them offline on the source while bringing them online on the destination.

--- | Branch: claude/issue-9156-20251128-1729

claude[bot] avatar Nov 30 '25 18:11 claude[bot]

@claude failed tests

ls_messages_and_errors.xml.zip (26,876 bytes)...100% Failed tests summary: Path : Start-DbaMigration/When using backup restore method/Should copy databases successfully Name : It Should copy databases successfully Result : Failed Message : Test failed but no error message could be extracted. Result: Failed | Test Name: Should copy databases successfully StackTrace : RawErrorRecord : No ErrorRecord Path : Start-DbaMigration/When using backup restore method/Should retain database properties after migration Name : It Should retain database properties after migration Result : Failed Message : Test failed but no error message could be extracted. Result: Failed | Test Name: Should retain database properties after migration StackTrace : RawErrorRecord : No ErrorRecord Path : Start-DbaMigration/When using backup restore method/Should return at least one result Name : It Should return at least one result Result : Failed Message : Test failed but no error message could be extracted. Result: Failed | Test Name: Should return at least one result StackTrace : RawErrorRecord : No ErrorRecord Path : Start-DbaMigration/When using last backup method/Should copy databases successfully Name : It Should copy databases successfully Result : Failed Message : Test failed but no error message could be extracted. Result: Failed | Test Name: Should copy databases successfully StackTrace : RawErrorRecord : No ErrorRecord Path : Start-DbaMigration/When using last backup method/Should retain database properties after migration Name : It Should retain database properties after migration Result : Failed Message : Test failed but no error message could be extracted. Result: Failed | Test Name: Should retain database properties after migration StackTrace : RawErrorRecord : No ErrorRecord Path : Start-DbaMigration/When using last backup method/Should return at least one result Name : It Should return at least one result Result : Failed Message : Test failed but no error message could be extracted. Result: Failed | Test Name: Should return at least one result StackTrace : RawErrorRecord : No ErrorRecord Path : Start-DbaMigration/When using SetSourceOffline parameter/Should set source database offline before migration and bring destination online Name : It Should set source database offline before migration and bring destination online Result : Failed Message : ErrorRecord: Expected a value, but got $null or empty. StackTrace : RawErrorRecord : Expected a value, but got $null or empty.

potatoqualitee avatar Dec 01 '25 06:12 potatoqualitee

Claude finished @potatoqualitee's task —— View job

Test failures fixed

  • [x] Read the test file to understand the failing tests
  • [x] Analyze the error messages and patterns
  • [x] Read the command implementation to understand expected behavior
  • [x] Identify the root cause of failures
  • [x] Fix the command to return database migration results
  • [x] Commit and push the fix

Root cause: Start-DbaMigration was calling Copy-DbaDatabase but not returning its output. Tests expected results with Type, Status, and Name properties to verify database migrations, but the function returned nothing.

Fix applied: Modified Start-DbaMigration.ps1:439-441 to output the results from Copy-DbaDatabase. This allows tests to:

  • Verify migration completed successfully
  • Check database migration status
  • Validate specific database properties
  • Test the new -SetSourceOffline parameter behavior

The function now properly returns database migration results for test verification while maintaining all existing functionality.

| Branch: claude/issue-9156-20251128-1729

claude[bot] avatar Dec 01 '25 06:12 claude[bot]