datanucleus-rdbms icon indicating copy to clipboard operation
datanucleus-rdbms copied to clipboard

Reverted JoinListStore#internalAdd to non bulk shift insertion strategy to avoid issue #464

Open chrisco484 opened this issue 1 year ago • 2 comments

Also: Fixed potential typo in passing shiftStmt instead of shiftBulkStmt in AbstractlistStore - did not resolve issue #464

This only reverts the bulk shift for 1-m relationships implemented via join tables as they are the only ones exhibiting the exception in MySQL.

Bulk shifts for 1-m relationships implemented by FK are still in place.

chrisco484 avatar Apr 19 '23 02:04 chrisco484

Note: this change is on the 5.2 branch only.

I'm not sure if Master branch exhibits the same issue with MySQL as I haven't had the time to install JDK 11 to test 6.x

chrisco484 avatar Apr 20 '23 03:04 chrisco484

I wont be ripping out code just because some corner case has some issue. You could provide a PR that allows a field to be marked with some metadata extension NOT to do bulk shift with that field perhaps ... that way the majority get the benefit of that code, and those who don't want it can opt out

andyjefferson avatar Apr 21 '23 13:04 andyjefferson