molfeat icon indicating copy to clipboard operation
molfeat copied to clipboard

correctly set base model to eval mode

Open cabreraalex opened this issue 1 year ago • 3 comments

Changelogs

  • enumerate the changes of that PR.

Checklist:

  • [ ] Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • [ ] Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
  • [ ] Update the API documentation if a new function is added, or an existing one is deleted. Eventually consider making a new tutorial for new features.
  • [ ] Write concise and explanatory changelogs below.
  • [ ] If possible, assign one of the following labels to the PR: feature, fix or test (or ask a maintainer to do it for you).

discussion related to that PR

cabreraalex avatar Aug 20 '24 00:08 cabreraalex

Good catch !

Thanks @cabreraalex , can you run the ruff linter, otherwise will do it and merge early tomorrow.

maclandrol avatar Aug 20 '24 00:08 maclandrol

Ruff seems to be from other areas, maybe easier for you!

I also had another issue with this part of the code - calling from_pretrained calls the DGLModel constructor with None store which causes it to instantiate and hangs for a long time failing to connect to GCP. IDK what the correct fix is, right now I'm passing in a random string as the store option to get it to not do that

cabreraalex avatar Aug 20 '24 01:08 cabreraalex

Can pull from main after #105 is merged.

I also had another issue with this part of the code - calling from_pretrained calls the DGLModel constructor with None store which causes it to instantiate and hangs for a long time failing to connect to GCP. IDK what the correct fix is, right now I'm passing in a random string as the store option to get it to not do that

Would you be able to share a snippet and also the system you are running on ? A lot of people seems to have issues with GCP on colab in particular.

maclandrol avatar Aug 20 '24 01:08 maclandrol