rlcard icon indicating copy to clipboard operation
rlcard copied to clipboard

There is a bug in rlcard.utils.logger.py

Open blackkingback opened this issue 3 years ago • 2 comments

Good day to you all! Recently I just got familiar with the RLCard package and I found a bug:

for the function : plot_curve(csv_path, save_path, algorithm) in the rlcard.utils.logger.py file, it doesn't have the right indent.

I think this function belongs to the Logger class in the same file. Please edit the file for it may cause confusion to the fresher coder(like me ) when they try this package.

blackkingback avatar Aug 17 '21 17:08 blackkingback

@blackkingback Thanks for the feedback. I agree with you that it will be clearer to put the plot_curve in the Logger. We will update the code.

daochenzha avatar Aug 21 '21 04:08 daochenzha

@blackkingback For this issue, I have moved the plot_curve function to utils.py to avoid any confusion. We still prefer to use a separate function instead of integrating the plotting into the logger. In this way, the logger is cleaner as it only logs.

daochenzha avatar Aug 25 '21 18:08 daochenzha