django-councilmatic icon indicating copy to clipboard operation
django-councilmatic copied to clipboard

In Miami-Dade County, the /council-members/ URL should be /commissioners/

Open ErnieAtLYD opened this issue 8 years ago • 3 comments

However, /council-members/ is hard coded: https://github.com/datamade/django-councilmatic/blob/master/councilmatic_core/templates/base.html#L36

ErnieAtLYD avatar May 12 '16 22:05 ErnieAtLYD

yeah, right now we only have settings to customize the display of vocab (CITY_VOCAB) but not to customize the urls. we'd welcome a PR that adds takes in url customizations from settings_jurisdiction.py (but also doesn't break existing councilmatic instances, & falls back to the defaults we have now)

cathydeng avatar May 13 '16 15:05 cathydeng

@cathydeng: Are there existing unit/functional tests people run to verify that old URLs work correctly?

ErnieAtLYD avatar May 13 '16 15:05 ErnieAtLYD

not that I know of. I think it's okay to go without url tests for councilmatic, since we have very few url patterns. I'd approach this by keeping the default url patterns in councilmatic_core/urls.py, but adding some extra url patterns based on if url pattern settings are configured, & then updating any hard-coded urls in councilmatic_core/templates/ accordingly.

at the same time though, I'd consider this low-priority, if you have other things to work on. In Chicago our council members are called aldermen, but we just figured that displaying custom vocab was good enough, without customizing the urls - it's all too easy to go down the rabbit hole of customizing everything :)

cathydeng avatar May 13 '16 18:05 cathydeng