code-challenge icon indicating copy to clipboard operation
code-challenge copied to clipboard

Published 20 hours ago • verified publisher icon datamade

Brent Oakes - Code Challenge Pull Request

Open boakes opened this issue 1 year ago • 0 comments

Overview

This is my Pull Request for the code-challenge. Below are some testing instructions to confirm that all requirements have been fulfilled.

Notes

If I had more time to work on this I would like to spend more time on error handling and make those responses have better pretty prints.

Testing Instructions

  • How to test this PR
  • Checkout this branch
  • Manual test:
    1. docker-compose build
    1. docker-compose up
    1. In a web browser go to: http://localhost:8000/
    1. Test 123 main st chicago il gets parsed to image
    1. Test 123 main st chicago il 123 main st returns an error.
    1. Confirm any additional addresses are parsed correctly/incorrectly
  • Automated test: docker-compose -f docker-compose.yml -f tests/docker-compose.yml run --rm app

boakes avatar Aug 29 '22 23:08 boakes