seq-logging icon indicating copy to clipboard operation
seq-logging copied to clipboard

onRemoteConfigChange

Open cheng93 opened this issue 1 year ago • 4 comments

The following PR https://github.com/datalust/seq-logging/pull/64 has removed the functionality introduced by https://github.com/datalust/seq-logging/pull/23. Which potentially allows seq to control the logging level.

Was this intended?

cheng93 avatar Feb 28 '24 10:02 cheng93

Hi @cheng93 :wave: Thanks for pointing that out. That doesn't look intentional to me, so I think we should re-introduce it.

KodrAus avatar Feb 28 '24 21:02 KodrAus

@cheng93 Were you previously using the dynamic level switching, or are you expecting to start using it?

KodrAus avatar Feb 28 '24 22:02 KodrAus

I'm looking to start using it.

I saw that it was defined in the types. https://github.com/datalust/seq-logging/blob/dev/index.d.ts#L11 So thought it was available.

See https://github.com/datalust/winston-seq/discussions/18

cheng93 avatar Feb 29 '24 08:02 cheng93

@cheng93 this would be a nice feature for the JS clients, but it is not on our short term roadmap. We are interested in a PR.

liammclennan avatar Mar 01 '24 00:03 liammclennan