AutoML icon indicating copy to clipboard operation
AutoML copied to clipboard

CI; req update; DOCS.md fix

Open Harkirat155 opened this issue 4 years ago • 6 comments

major update:

  • introduction of CI

The patch is efficient,

NOTE: it appears some dependencies in requirements are not being used anywhere.

Harkirat155 avatar Oct 25 '20 18:10 Harkirat155

Yeah, I think you can delete some of the requirements

memetics19 avatar Oct 31 '20 11:10 memetics19

@Harkirat155 can you add some lintings too

memetics19 avatar Oct 31 '20 11:10 memetics19

Just to be clear, do you mean to add them in requirements? This would work for the supported IDEs. (Also, these are just dev requirements, it would be optimal to create a separate dev-requirements.txt for its purpose.)

Or else if intended for them to be added as a configuration, there are a few options,

  • Map some scripts to git-hooks, and add those scripts to the code-base. Git-hooks(more on it here, and here) can be preferred as they are triggered upon specific git actions(commit, push, etc.)

  • Use a more obvious method, like pylint or flake8 but those could depend on local execution (The checks could be added to CI, and later exported back as logs).

Harkirat155 avatar Nov 02 '20 12:11 Harkirat155

yeah I was talking about pylints or flake8 linting for CI checks

memetics19 avatar Nov 11 '20 20:11 memetics19

@NoamRosenberg Check this, i think it's ready to merge to Dev/SDK branch

memetics19 avatar Dec 04 '20 16:12 memetics19

@Harkirat155 Really want to thank you for this. It's not quite ready for master yet as many things have changed. I've created a pull request to @memetics19, he will try to fix the conflicts!

NoamRosenberg avatar Dec 06 '20 07:12 NoamRosenberg