datalens icon indicating copy to clipboard operation
datalens copied to clipboard
verified publisher icon datalens-tech

Need Chinese translation

Open learningpro opened this issue 2 years ago • 5 comments

Will you provide Chinese translation ? Or how could I make a pull request on translation

learningpro avatar Oct 05 '23 02:10 learningpro

https://github.com/datalens-tech/datalens-ui/pull/40 Is any one here can help approve this PR?

learningpro avatar Oct 09 '23 07:10 learningpro

Hi! Thank you for your contribution.

I afraid we can't just merge that PR right now since both our i18n tools and UI components are currently not suitable for Chinese. App probably just won't be able to start.

We need some time to analyze this task and, if needed, adapt our tools.

resure avatar Oct 09 '23 19:10 resure

Hi! Thank you for your contribution.

I afraid we can't just merge that PR right now since both our i18n tools and UI components are currently not suitable for Chinese. App probably just won't be able to start.

We need some time to analyze this task and, if needed, adapt our tools.

I read through the code and found that gravity-ui doesn't have cn language, it only has en and ru, maybe we should update gravity-ui/i18n first. https://github.com/gravity-ui/i18n/blob/main/src/index.ts

learningpro avatar Oct 12 '23 04:10 learningpro

I read through the code and found that gravity-ui doesn't have cn language, it only has en and ru, maybe we should update gravity-ui/i18n first. https://github.com/gravity-ui/i18n/blob/main/src/index.ts

Yes, that's the plan — add support for additional languages in gravity i18n, uikit, etc.

We are discussing that with our colleagues (maintainers of gravity libraries) right now, we'll add links to related tasks soon.

resure avatar Oct 13 '23 09:10 resure

Related issue in Gravity UIKit: https://github.com/gravity-ui/uikit/issues/1065

resure avatar Oct 24 '23 18:10 resure