marker icon indicating copy to clipboard operation
marker copied to clipboard

Fix KeyError (refs) when `--disable_links` is set to True

Open fatualux opened this issue 10 months ago • 1 comments

Proposal to fix this issue

No explaination needed.

image

fatualux avatar Feb 26 '25 11:02 fatualux

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


0 out of 3 committers have signed the CLA.
:x: @Francesco Zubani
:x: @fatualux
:x: @FZ
Francesco Zubani, fatualux, FZ seem not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

github-actions[bot] avatar Feb 26 '25 11:02 github-actions[bot]

Are you sure about it ? if self.check_line_spans(lines): page_lines[page_id] = lines # Changes to the page object are not reflected in the dictionary output refs = page.get("refs") if refs is not None: self.page_refs[page_id] = page["refs"] this is what you are suggesting should it the refs = be outside the if statement instead of being inside the if self.check_line_spans

SaiMadhusudan avatar Mar 21 '25 15:03 SaiMadhusudan

This is fixed in the new release (https://github.com/VikParuchuri/marker/releases/tag/v1.6.2). Thanks for the PR!

tarun-menta avatar Mar 26 '25 22:03 tarun-menta