druid-operator icon indicating copy to clipboard operation
druid-operator copied to clipboard

fix: put Druid crds in the appropriate folder specified by Helm

Open TessaIO opened this issue 1 year ago • 1 comments

This PR aims to put CRDs folder in the appropriate folder specified by Helm which is charts/crds, so that we can skip installing CRDs whenever we want. Please refer to: https://helm.sh/docs/topics/charts/#custom-resource-definitions-crds

Description


This PR has:

  • [x] been tested on a real K8S cluster to ensure creation of a brand new Druid cluster works.
  • [x] been tested for backward compatibility on a real K*S cluster by applying the changes introduced here on an existing Druid cluster. If there are any backward incompatible changes then they have been noted in the PR description.
  • [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • [x] added documentation for new or modified features or behaviors.

Key changed/added files in this PR
  • chart/templates/crds

TessaIO avatar May 17 '24 14:05 TessaIO

@AdheipSingh is the test flaky? It seems that it's not related to the change.

TessaIO avatar May 17 '24 17:05 TessaIO

Would really like to see this getting merged, for some context:

This would enable users to spin up multiple druid clusters where every cluster is managed by a separate operator, currently this doesn't work because installing a second operator will fail, because the CRD is already present. This PR enables the use of --skip-crds during helm install which solves this problem.

mariuskimmina avatar Jun 03 '24 13:06 mariuskimmina

ping @AdheipSingh

TessaIO avatar Jun 03 '24 13:06 TessaIO