datahub icon indicating copy to clipboard operation
datahub copied to clipboard

Published 20 hours ago • verified publisher icon datahub-project

Datahub ingest uses external connections for upgrade checks

Open fackyhigh opened this issue 1 year ago • 2 comments

Describe the bug Hello. My company has a requirement that all software should use only internal network. Our network software spotted that datahub connects to pypi.org and api.github.com. I found it in the code and it happens when the program tries to check new versions. https://github.com/datahub-project/datahub/blob/651998de44afcac6efce44aadac6b04cb5e0ff30/metadata-ingestion/src/datahub/upgrade/upgrade.py#L54 https://github.com/datahub-project/datahub/blob/651998de44afcac6efce44aadac6b04cb5e0ff30/metadata-ingestion/src/datahub/upgrade/upgrade.py#L96 https://github.com/datahub-project/datahub/blob/651998de44afcac6efce44aadac6b04cb5e0ff30/metadata-ingestion/src/datahub/upgrade/upgrade.py#L152

To Reproduce Steps to reproduce the behavior:

  1. run Wireshark
  2. run datahub ingest run
  3. find the traffic to pypi and github
  4. See error

Expected behavior Have a flag for CLI to disable updates checks or a configuration parameter.

fackyhigh avatar Dec 27 '23 15:12 fackyhigh

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

github-actions[bot] avatar Jan 27 '24 01:01 github-actions[bot]

@fackyhigh this is intended behavior. We'd accept a PR that adds an environment variable which disables the version checks, but it's not particularly high priority for us at the moment.

hsheth2 avatar Jan 30 '24 21:01 hsheth2

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

github-actions[bot] avatar Mar 02 '24 01:03 github-actions[bot]

This issue was closed because it has been inactive for 30 days since being marked as stale.

github-actions[bot] avatar Apr 01 '24 01:04 github-actions[bot]