datahub icon indicating copy to clipboard operation
datahub copied to clipboard

protobuf error occurs on certain versions and above.

Open wngus606 opened this issue 2 years ago • 13 comments

Describe the bug

If I run a jar file with v0.10.3 or later, an error occurs.

Exception in thread "main" java.lang.NoSuchMethodError: 'datahub.shaded.jackson.core.JsonFactory datahub.shaded.jackson.core.JsonFactory.setStreamReadConstraints(datahub.shaded.jackson.core.StreamReadConstraints)'

However, I run it with the v0.10.2 version of the jar and it works fine.

To Reproduce https://datahubspace.slack.com/archives/C02TYRDKCBD/p1687940673159259?thread_ts=1687940391.960039&cid=C02TYRDKCBD

Desktop (please complete the following information):

  • OS: Mac OS
  • Version: v0.10.3 or later

wngus606 avatar Jun 29 '23 10:06 wngus606

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

github-actions[bot] avatar Jul 30 '23 01:07 github-actions[bot]

the smae thing happens in v0.10.5

wngus606 avatar Aug 08 '23 04:08 wngus606

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

github-actions[bot] avatar Sep 09 '23 01:09 github-actions[bot]

Same issue with the version [0.11.0-1] and [0.11.0-2]. Using the Java package io.acryl:datahub-protobuf in a standalone project using Gradle (8.1.1).

dmnparent avatar Sep 29 '23 11:09 dmnparent

Is this issue still unresolved?

wngus606 avatar Sep 29 '23 13:09 wngus606

Thanks for the detailed error report - we're looking into this issue!

hsheth2 avatar Oct 03 '23 06:10 hsheth2

We're dependent on Jackson 2.15+, you need to include this in your build. Will update the example. Versions prior to this are vulnerable to critical DoS CVEs.

RyanHolstien avatar Oct 03 '23 20:10 RyanHolstien

@RyanHolstien I'm running into the same issue. Could you give an example of how to add this dep? Apparently this somehow needs to get added as a shadoJar? As someone not coming from the java world I'm struggling to get this running.

phil-schreiber avatar Oct 26 '23 13:10 phil-schreiber

@hsheth2 @david-leifker any progress on this issue? I want to upgrade datahub-protobuf to the latest version but staying blocked by this

zettelin avatar Nov 17 '23 09:11 zettelin

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

github-actions[bot] avatar Dec 18 '23 01:12 github-actions[bot]

Is this issue in progress? @hsheth2 @david-leifker

wngus606 avatar Jan 08 '24 01:01 wngus606

I found the place where this problem occurred. It seems that the error occurs when you call the setStreamReadConstraints function in the constructor part of the

  • EventFormatter https://github.com/datahub-project/datahub/blob/b0060cec27d09e69ce3913b6d5b8a7ea8dffde76/metadata-integration/java/datahub-client/src/main/java/datahub/event/EventFormatter.java#L35
  • FileEmitter.java https://github.com/datahub-project/datahub/blob/b0060cec27d09e69ce3913b6d5b8a7ea8dffde76/metadata-integration/java/datahub-client/src/main/java/datahub/client/file/FileEmitter.java#L56
  • RestEmitter.java https://github.com/datahub-project/datahub/blob/b0060cec27d09e69ce3913b6d5b8a7ea8dffde76/metadata-integration/java/datahub-client/src/main/java/datahub/client/rest/RestEmitter.java#L88

Is it possible to fix it? @hsheth2 @david-leifker

wngus606 avatar Jan 10 '24 06:01 wngus606

I've just encountered this issue with the v0.12.1 version of datahub-protobuf. Version v0.10.2 seems to work fine.

BNikola avatar Jan 30 '24 15:01 BNikola

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

github-actions[bot] avatar Mar 01 '24 01:03 github-actions[bot]

This issue was closed because it has been inactive for 30 days since being marked as stale.

github-actions[bot] avatar Mar 31 '24 01:03 github-actions[bot]