datahub
datahub copied to clipboard
fix(logging): Remove lombok as source of slf4j-api
Remove lombok as source of slf4j-api, convert to compileOnly where possible
Checklist
- [ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
- [ ] Links to related issues (if applicable)
- [ ] Tests for the changes have been added/updated (if applicable)
- [ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
- [ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub
Unit Test Results (build & test)
621 tests ±0 617 :heavy_check_mark: ±0 15m 41s :stopwatch: -6s 157 suites ±0 4 :zzz: ±0 157 files ±0 0 :x: ±0
Results for commit e1c6f0b3. ± Comparison against base commit 4876fdd0.
:recycle: This comment has been updated with latest results.
Unit Test Results (metadata ingestion)
8 files 8 suites 58m 23s :stopwatch: 766 tests 764 :heavy_check_mark: 2 :zzz: 0 :x: 1 534 runs 1 529 :heavy_check_mark: 5 :zzz: 0 :x:
Results for commit e1c6f0b3.
:recycle: This comment has been updated with latest results.
Looks like tests are failing, probably need a testCompile dep on logback
- removal of htrace, removed shaded log4j impl, which caused an slf4 forwarder to point to log4j forwarder (infinite loop)
- applied project wide transitive exclusions to directly pick versions and impl (logback)
- some upstream dependencies depend on the log4j-core, not just log4j-api, requires log4j-impl to compile
- slf4j unlike log4j doesn’t tolerate alt impls (or complains) or different impl versions, especially major ones
- lombok includes an slf4j-api version and we are incorrectly setting
compile
instead ofcompileOnly
- most of our modules are libraries and therefore should only bring in slf4j-api and not include an impl (exceptions frontend, war, consumers, etc). this leads to some runtimeOnly dependencies for library tests