datahub icon indicating copy to clipboard operation
datahub copied to clipboard

[WIP] Remove confluent schema registry hard dependency

Open pedro93 opened this issue 2 years ago • 2 comments

Checklist

Purpose of this PR is to remove the schema registry as a hard dependency from DataHub. In order to do that, the PR creates a new module kafka-avro-serde which implements Kafka-compatible Serializer & Deserializer classes.

Also included is a static, internal light schema registry implementation to know how to serde DataHub's Avro records (MCP, MCL and it's variants).

Based on https://github.com/datahub-project/datahub/pull/5232, kudos to @tmnd1991!

  • [ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • [ ] Links to related issues (if applicable)
  • [x] Tests for the changes have been added/updated (if applicable)
  • [ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • [ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

pedro93 avatar Nov 25 '22 16:11 pedro93

Unit Test Results (build & test)

543 tests   543 :heavy_check_mark:  15m 16s :stopwatch: 131 suites      0 :zzz: 131 files        0 :x:

Results for commit 4d32e02e.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Nov 25 '22 16:11 github-actions[bot]

Unit Test Results (metadata ingestion)

       8 files         8 suites   1h 2m 14s :stopwatch:    766 tests    756 :heavy_check_mark: 2 :zzz:   8 :x: 1 534 runs  1 514 :heavy_check_mark: 5 :zzz: 15 :x:

For more details on these failures, see this check.

Results for commit 4d32e02e.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Nov 25 '22 16:11 github-actions[bot]

CI failures appear unrelated and caused by https://github.com/datahub-project/datahub/pull/7059. We should be ok to merge this as long as the 3.10 tests pass.

hsheth2 avatar Jan 17 '23 20:01 hsheth2