datahub icon indicating copy to clipboard operation
datahub copied to clipboard

feat(ui) - added panel to track change events of dataset

Open neojunjie opened this issue 2 years ago • 7 comments

Checklist

  • [ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • [ ] Links to related issues (if applicable)
  • [ ] Tests for the changes have been added/updated (if applicable)
  • [ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • [ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Currently, there is no easy way (visually) for anyone (consumers, owners, producers) to keep track of what is going on with the dataset. This PR will add a new panel to display all the changes related to the dataset.

neojunjie avatar Nov 01 '22 06:11 neojunjie

Unit Test Results (build & test)

602 tests  ±0   598 :heavy_check_mark: ±0   11m 40s :stopwatch: +3s 149 suites ±0       4 :zzz: ±0  149 files   ±0       0 :x: ±0 

Results for commit 0f4bc973. ± Comparison against base commit 0a0cf70b.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Nov 01 '22 07:11 github-actions[bot]

Pulling screenshots from Slack conversation

change_events change_events2

maggiehays avatar Nov 01 '22 19:11 maggiehays

Hi guys!

First of all, awesome work! I'm really excited to see this feature come to fruition. We've gone long enough without :).

The UI for this pass is a great starting point. Where we are hoping to go is something like the following:

Screen Shot 2022-11-01 at 4 07 03 PM

For documentation, we are hoping to display rich diffs that show the before and after image of a given doc.

Where each activity entry has rich content, ability to select entities, and more. Is this something you are willing to work with us to get to?

We're happy to provide support and further clarity where possible.

Cheers, John

jjoyce0510 avatar Nov 01 '22 23:11 jjoyce0510

Hi all

Sure. Willing to work with you guys to move to the desired state.

On Wed, Nov 2, 2022, 07:09 John Joyce @.***> wrote:

Hi guys!

First of all, awesome work! I'm really excited to see this feature come to fruition. We've gone long enough without :).

The UI for this pass is a great starting point. Where we are hoping to go is something like the following:

[image: Screen Shot 2022-11-01 at 4 07 03 PM] https://user-images.githubusercontent.com/17549204/199359128-35cb0e80-5dac-427a-a533-c35ab8defc95.png

Where each activity entry has rich content, ability to select entities, and more. Is this something you are willing to work with us to get to?

We're happy to provide support and further clarity where possible.

Cheers, John

— Reply to this email directly, view it on GitHub https://github.com/datahub-project/datahub/pull/6325#issuecomment-1299339537, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANGABQ33XSBLRLKTDSKKTDWGGPKPANCNFSM6AAAAAARTYLGYA . You are receiving this because you modified the open/close state.Message ID: @.***>

neojunjie avatar Nov 01 '22 23:11 neojunjie

Let us know if you need any support here :)

jjoyce0510 avatar Nov 15 '22 00:11 jjoyce0510

Hi John

I will be away for 2 weeks.

On Tue, Nov 15, 2022, 08:47 John Joyce @.***> wrote:

Let us know if you need any support here :)

— Reply to this email directly, view it on GitHub https://github.com/datahub-project/datahub/pull/6325#issuecomment-1314603611, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANGABTNN7W7XXDHNMP6WYTWILMSJANCNFSM6AAAAAARTYLGYA . You are receiving this because you modified the open/close state.Message ID: @.***>

neojunjie avatar Nov 15 '22 01:11 neojunjie

Hi @neojunjie let us know when you're planning on picking this up again!

aditya-radhakrishnan avatar Dec 02 '22 18:12 aditya-radhakrishnan

Going to close this PR until this is ready to be picked up again. Please feel free to reopen @neojunjie!

aditya-radhakrishnan avatar Dec 07 '22 19:12 aditya-radhakrishnan

Also happy to work with you to get this to the finish line!

aditya-radhakrishnan avatar Dec 07 '22 19:12 aditya-radhakrishnan