datahub icon indicating copy to clipboard operation
datahub copied to clipboard

Kafka retry mdclp

Open djordje-mijatovic opened this issue 2 years ago • 3 comments

Checklist

  • [ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • [ ] Links to related issues (if applicable)
  • [ ] Tests for the changes have been added/updated (if applicable)
  • [ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • [ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Split Kafka Listener from MetadataChangeLogProcessor into 4 different Listeners (as there are 4 hooks now) and add separated Retry mechanism to each of them.

djordje-mijatovic avatar Oct 31 '22 09:10 djordje-mijatovic

Unit Test Results (build & test)

633 tests  ±0   629 :heavy_check_mark: ±0   15m 57s :stopwatch: +10s 162 suites ±0       4 :zzz: ±0  162 files   ±0       0 :x: ±0 

Results for commit 43bbc599. ± Comparison against base commit eeb7a9df.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Nov 01 '22 08:11 github-actions[bot]

(This is under review by Acryl team)

jjoyce0510 avatar Nov 30 '22 17:11 jjoyce0510

Hello @djordje-mijatovic

Thank you for your PR. Could you please add change the PR title to match our guidelines and also add a description what you are trying to accomplish so we have a good git log in case future contributors need to understand?

Please see: https://github.com/datahub-project/datahub/blob/master/docs/CONTRIBUTING.md#commit-message-format for our guidelines.

pedro93 avatar Nov 30 '22 17:11 pedro93

Apologies for the delay @djordje-mijatovic!

We are taking a look at the latest shortly.

jjoyce0510 avatar Jan 10 '23 00:01 jjoyce0510

Considering the significant architectural changes this PR proposes, we need time to evaluate the impact on deployments and needs to be done carefully with a migration plan. Other pressing work currently takes priority over this, but we have it on our priority list.

RyanHolstien avatar Jan 12 '23 16:01 RyanHolstien

Going to be closing this one for now. Let's reopen if it becomes relevant again.

Cheers John

jjoyce0510 avatar Jan 24 '23 23:01 jjoyce0510