datahub icon indicating copy to clipboard operation
datahub copied to clipboard

fix(ingestion/vertica): support ingestion of tables with precision field in timestamp values in Vertica

Open inancdokurel opened this issue 2 years ago • 3 comments

This PR aims to fix the problem referred in the #5295

It is not a perfect fix, however it allows timestamp fields with precision values to be ingested into Datahub

Checklist

  • [ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • [x] Links to related issues (if applicable)
  • [ ] Tests for the changes have been added/updated (if applicable)
  • [ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • [ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

inancdokurel avatar Oct 26 '22 20:10 inancdokurel

Unit Test Results (metadata ingestion)

       8 files         8 suites   1h 5m 17s :stopwatch:    752 tests    750 :heavy_check_mark: 2 :zzz: 0 :x: 1 506 runs  1 501 :heavy_check_mark: 5 :zzz: 0 :x:

Results for commit fa907113.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Oct 27 '22 03:10 github-actions[bot]

Unit Test Results (build & test)

633 tests  +12   629 :heavy_check_mark: +12   15m 45s :stopwatch: -4s 162 suites +  5       4 :zzz: ±  0  162 files   +  5       0 :x: ±  0 

Results for commit fa907113. ± Comparison against base commit f69b4699.

This pull request removes 4 and adds 16 tests. Note that renamed tests count towards both.
com.datahub.authorization.ranger.RangerAuthorizerTest ‑ testAuthorizationAllow
com.datahub.authorization.ranger.RangerAuthorizerTest ‑ testAuthorizationDeny
com.datahub.authorizer.plugin.ranger.TestDataHubRangerAuthPlugin ‑ testLookupResource
com.datahub.authorizer.plugin.ranger.TestDataHubRangerAuthPlugin ‑ testValidateConfig
com.datahub.plugins.auth.TestConfig ‑ testConfig
com.datahub.plugins.auth.TestConfigProvider ‑ testConfigurationLoading
com.datahub.plugins.auth.TestConfigValidationUtils ‑ testListShouldNotBeEmpty
com.datahub.plugins.auth.TestConfigValidationUtils ‑ testListShouldNotHaveDuplicate
com.datahub.plugins.auth.TestConfigValidationUtils ‑ testMapShouldNotBeEmpty
com.datahub.plugins.auth.TestConfigValidationUtils ‑ testWhiteSpacesValidation
com.datahub.plugins.auth.TestIsolatedClassLoader ‑ testAuthenticatorPlugin
com.datahub.plugins.auth.TestIsolatedClassLoader ‑ testAuthorizerPlugin
com.datahub.plugins.auth.TestIsolatedClassLoader ‑ testDuplicatePluginName
com.datahub.plugins.auth.TestIsolatedClassLoader ‑ testIncorrectImplementation
…

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Oct 27 '22 03:10 github-actions[bot]

Anybody willing to review and provide comments?

inancdokurel avatar Nov 15 '22 09:11 inancdokurel