datahub icon indicating copy to clipboard operation
datahub copied to clipboard

Strange behaviour on the glossary term relations: inherits and contains

Open devantler opened this issue 2 years ago • 1 comments

Describe the bug

The inherited relation on glossary terms seems to be reversed. When adding inheritance from one glossary term to another, the parent of those two has the children's entities in its related entities. I would expect the child glossary term to inherit all the related entities from its parent.

The contains relation does not seem to do anything.

To Reproduce Steps to reproduce the behaviour:

  1. Add two Glossary Terms
  2. Let one Glossary Term inherit from another one.
  3. Add the Glossary Terms to some entities.
  4. Observe that the inherited relation is reversed.

Expected behaviour

I expect the child to inherit the parent's entities, as this is the expected behaviour of normal inheritance. Am I mistaken in this, or is something afoot?

I expect the contain relation to add the contained glossary term entities to the glossary term owning the relation.

Desktop (please complete the following information):

  • OS: macOS (datahub docker quickstart)
  • Browser: Safari
  • Version 0.9.0

devantler avatar Oct 25 '22 19:10 devantler

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

github-actions[bot] avatar Nov 25 '22 02:11 github-actions[bot]

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

github-actions[bot] avatar Jan 08 '23 02:01 github-actions[bot]

Hi @devantler I'm a little confused by the issue. Glossary terms can only be children of Glossary nodes, not Terms. I'm not sure how you're observing that the inherited relation is reversed. Could you please given some more context and maybe post some screenshots? Thank you!

aditya-radhakrishnan avatar Jan 24 '23 05:01 aditya-radhakrishnan

@aditya-radhakrishnan I am very occupied with work and my thesis in the coming time, so I will not be able to help further with this issue. But if it is not reproducible, I believe it might have been fixed in the meantime. It was very obvious when we discovered it in class, so I think you would have noticed the issue if it was still an issue.

Feel free to close the issue. When I need DataHub again, I will make sure to check if it is still an issue and reopen this issue if it is :-)

Reminder to @devantler to check up on this.

devantler avatar Jan 24 '23 16:01 devantler

Got it! Yes please feel free to reopen once you get back to DataHub, and good luck with your work and thesis!

Thank you

aditya-radhakrishnan avatar Jan 24 '23 18:01 aditya-radhakrishnan