datahub
datahub copied to clipboard
fix(ui) Followups to recent changes to UI ingestion forms
We recently merged in a big change to ingestion forms in the UI and this PR addresses some followups after that.
- Pass in
removeMargin
optional prop for styling to SecretField - Add typescript typing to our
RECIPE_FIELDS
object - Simplify value setting logic by allowing our main value setter to work for
fieldPath
s that are both strings and a list of strings (for field keys that are dotted ie.sasl.username
) - Update some incorrect tooltips
Checklist
- [ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
- [ ] Links to related issues (if applicable)
- [ ] Tests for the changes have been added/updated (if applicable)
- [ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
- [ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub
Unit Test Results (build & test)
499 tests ±0 499 :heavy_check_mark: ±0 8m 15s :stopwatch: -5s 115 suites ±0 0 :zzz: ±0 115 files ±0 0 :x: ±0
Results for commit fcd2415c. ± Comparison against base commit 2b2488e6.
:recycle: This comment has been updated with latest results.
are the dotted fields only able to be provided that way? so if you put
sasl: username: true
that would be considered invalid in the kafka recipe?
@gabe-lyons I'm actually not positive. I'd like to think this would still be considered valid, but I never dug too deep into it. I just know in our docs and example recipe we have the dotted key like sasl.username: {value}
so I just decided to keep that convention when building through the form