datahub icon indicating copy to clipboard operation
datahub copied to clipboard

feat(model): Add optional message field to auditstamp

Open dexter-mh-lee opened this issue 2 years ago • 2 comments

Checklist

  • [ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • [ ] Links to related issues (if applicable)
  • [ ] Tests for the changes have been added/updated (if applicable)
  • [ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • [ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

dexter-mh-lee avatar Jun 01 '22 03:06 dexter-mh-lee

Unit Test Results (build & test)

334 tests  +  1   332 :heavy_check_mark:  - 1   49s :stopwatch: - 1m 41s   89 suites +12       0 :zzz: ±0    89 files   +12       2 :x: +2 

For more details on these failures, see this check.

Results for commit 5f5e3614. ± Comparison against base commit d6239f82.

This pull request removes 99 and adds 100 tests. Note that renamed tests count towards both.
com.datahub.authentication.authenticator.AuthenticatorChainTest ‑ testAuthenticateFailure
com.datahub.authentication.authenticator.AuthenticatorChainTest ‑ testAuthenticateSuccess
com.datahub.authentication.authenticator.AuthenticatorChainTest ‑ testAuthenticateThrows
com.datahub.authentication.authenticator.DataHubSystemAuthenticatorTest ‑ testAuthenticateFailureMismatchingCredentials
com.datahub.authentication.authenticator.DataHubSystemAuthenticatorTest ‑ testAuthenticateFailureMissingAuthorizationHeader
com.datahub.authentication.authenticator.DataHubSystemAuthenticatorTest ‑ testAuthenticateFailureMissingBasicCredentials
com.datahub.authentication.authenticator.DataHubSystemAuthenticatorTest ‑ testAuthenticateSuccessDelegatedActor
com.datahub.authentication.authenticator.DataHubSystemAuthenticatorTest ‑ testAuthenticateSuccessNoDelegatedActor
com.datahub.authentication.authenticator.DataHubSystemAuthenticatorTest ‑ testInit
com.datahub.authentication.authenticator.DataHubTokenAuthenticatorTest ‑ testAuthenticateFailureInvalidToken
…
com.datahub.authorizer.plugin.ranger.TestDataHubRangerAuthPlugin ‑ testLookupResource
com.datahub.authorizer.plugin.ranger.TestDataHubRangerAuthPlugin ‑ testValidateConfig
com.linkedin.datahub.graphql.resolvers.dashboard.DashboardStatsSummaryTest ‑ testGetException
com.linkedin.datahub.graphql.resolvers.dashboard.DashboardStatsSummaryTest ‑ testGetSuccess
com.linkedin.datahub.graphql.resolvers.dataset.DatasetStatsSummaryResolverTest ‑ testGetException
com.linkedin.datahub.graphql.resolvers.dataset.DatasetStatsSummaryResolverTest ‑ testGetSuccess
com.linkedin.datahub.graphql.resolvers.delete.BatchUpdateSoftDeletedResolverTest ‑ testGetEntityClientException
com.linkedin.datahub.graphql.resolvers.delete.BatchUpdateSoftDeletedResolverTest ‑ testGetFailureResourceDoesNotExist
com.linkedin.datahub.graphql.resolvers.delete.BatchUpdateSoftDeletedResolverTest ‑ testGetSuccessExistingStatus
com.linkedin.datahub.graphql.resolvers.delete.BatchUpdateSoftDeletedResolverTest ‑ testGetSuccessNoExistingStatus
…

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jun 01 '22 03:06 github-actions[bot]

Let's wait til we release new CLI version - this has potential to break the old actions framework because its not forwards compatible

jjoyce0510 avatar Jun 06 '22 23:06 jjoyce0510

closing in favor of https://github.com/datahub-project/datahub/pull/5611

gabe-lyons avatar Aug 10 '22 18:08 gabe-lyons