datahub icon indicating copy to clipboard operation
datahub copied to clipboard

feat(deletion & rollback): Server & Client side changes to support timeseries aspect deletion & rollback.

Open rslanka opened this issue 2 years ago • 2 comments

This PR contains the following server-side changes to support timeseries aspect deletion and rollback:

  1. Deletion by query(filter) core implementation + unit tests
  2. Update to the delete API of EntityResource.
  3. Update to the rollback API of BatchIngestionRunResource(run).

Checklist

  • [x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • [ ] Links to related issues (if applicable)
  • [x] Tests for the changes have been added/updated (if applicable)
  • [ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • [ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

rslanka avatar Apr 27 '22 00:04 rslanka

Unit Test Results (build & test)

571 tests  ±0   571 :heavy_check_mark: ±0   14m 30s :stopwatch: - 1m 12s 141 suites ±0       0 :zzz: ±0  141 files   ±0       0 :x: ±0 

Results for commit 0e114540. ± Comparison against base commit e556bcb3.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Apr 27 '22 00:04 github-actions[bot]

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   55m 44s :stopwatch: -5s    692 tests ±0     689 :heavy_check_mark: ±0  3 :zzz: ±0  0 :x: ±0  1 384 runs  ±0  1 378 :heavy_check_mark: ±0  6 :zzz: ±0  0 :x: ±0 

Results for commit 0e114540. ± Comparison against base commit e556bcb3.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 23 '22 20:05 github-actions[bot]