datahub
datahub copied to clipboard
feat(redash): add ability to filter redash metadata by database
Checklist
- [x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
- [ ] Links to related issues (if applicable)
- [ ] Tests for the changes have been added/updated (if applicable)
- [x] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
- [ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub
Unit Test Results (build & test)
98 files + 2 98 suites +2 18m 32s :stopwatch: - 2m 39s 718 tests +29 645 :heavy_check_mark: +15 67 :zzz: +8 6 :x: +6
For more details on these failures, see this check.
Results for commit c12356b1. ± Comparison against base commit fa4cc3ad.
:recycle: This comment has been updated with latest results.
Unit Test Results (metadata ingestion)
4 files 4 suites 1h 3m 15s :stopwatch: 448 tests 447 :heavy_check_mark: 0 :zzz: 1 :x: 1 742 runs 1 692 :heavy_check_mark: 49 :zzz: 1 :x:
For more details on these failures, see this check.
Results for commit c12356b1.
:recycle: This comment has been updated with latest results.
@treff7es Done! For some reason i forgot to commit the other modifications :sweat_smile:
@DantasB thanks, now there are a few mypy validation error -> https://github.com/datahub-project/datahub/runs/5984956469?check_suite_focus=true#step:6:1126
src/datahub/ingestion/source/redash.py:503: error: Argument 1 to "_get_database_name_based_on_datasource" of "RedashSource" has incompatible type "Optional[Any]"; expected "Dict[Any, Any]"
src/datahub/ingestion/source/redash.py:552: error: Argument 1 to "allowed" of "AllowDenyPattern" has incompatible type "Optional[str]"; expected "str"
src/datahub/ingestion/source/redash.py:674: error: Argument 1 to "allowed" of "AllowDenyPattern" has incompatible type "Optional[str]"; expected "str"
Please, can you fix those as well? Let me know if you need any help.
@DantasB hey, let me know if you need help resolving these mypy issues:
src/datahub/ingestion/source/redash.py:551: error: Argument 1 to "allowed" of "AllowDenyPattern" has incompatible type "Optional[str]"; expected "str"
src/datahub/ingestion/source/redash.py:673: error: Argument 1 to "allowed" of "AllowDenyPattern" has incompatible type "Optional[str]"; expected "str"
@DantasB hey, let me know if you need help resolving these mypy issues:
src/datahub/ingestion/source/redash.py:551: error: Argument 1 to "allowed" of "AllowDenyPattern" has incompatible type "Optional[str]"; expected "str" src/datahub/ingestion/source/redash.py:673: error: Argument 1 to "allowed" of "AllowDenyPattern" has incompatible type "Optional[str]"; expected "str"
Hey @treff7es sorry for taking too long to fix this linter, it's just because the college activities return back recently so it's beeing quite hard to handle a lot of things hahaha! I'll try to fix that today, if it's beeing to hard i'll ask you for help, ok? Thanks!
@treff7es now i think that mypy will not fail again.
We are closing the PR due to dormancy.
We've not heard this feature request for the Redash source since this was opened.
Thanks for the awesome contribution @DantasB! Please reach out if you'd like to start up this thread again, and we'll work with you to figure it out.
Cheers John