datahub icon indicating copy to clipboard operation
datahub copied to clipboard

feat(graphql): Add sorting option to GraphQL search

Open nmbryant opened this issue 2 years ago • 10 comments

Checklist

  • [x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • [ ] Links to related issues (if applicable)
  • [ ] Tests for the changes have been added/updated (if applicable)
  • [ ] Docs related to the changes have been added/updated (if applicable)

nmbryant avatar Nov 16 '21 19:11 nmbryant

If there are any tests related to this, please let me know. I took a look and couldn't find tests related to the GraphQL queries. Also, please let me know if there are any particular docs that need to be updated

nmbryant avatar Nov 16 '21 19:11 nmbryant

Unit Test Results

     37 files       37 suites   26m 53s :stopwatch:    589 tests    537 :heavy_check_mark: 52 :zzz: 0 :x: 1 324 runs  1 256 :heavy_check_mark: 68 :zzz: 0 :x:

Results for commit be1790eb.

github-actions[bot] avatar Nov 16 '21 19:11 github-actions[bot]

Thanks for the PR @nmbryant! Will be taking a look this week.

jjoyce0510 avatar Nov 18 '21 17:11 jjoyce0510

Our use case with DataHub plans on using a couple of single-entity searches so we wanted to add sorting on the GraphQL side rather than do the sorting on the UI side. I do need to take a further look at searchAcrossEntities, but I think the single entity search is what we will want to use.

nmbryant avatar Nov 20 '21 15:11 nmbryant

@jjoyce0510 Is this something that you want merged upstream? If it is, I can resolve the merge conflicts and make changes based on any feedback you may have. Otherwise, I will just copy the changes into our fork and close this PR.

nmbryant avatar Dec 14 '21 20:12 nmbryant

@nmbryant We'd definitely be interested in taking this upstream, yes! If you're able to clear the conflicts, we can work to quickly get it in

jjoyce0510 avatar Jan 05 '22 16:01 jjoyce0510

Awesome, I have the merge conflicts resolved locally just need to do some testing tomorrow before it's ready to go.

nmbryant avatar Jan 06 '22 15:01 nmbryant

@jjoyce0510 Fixed the merge conflicts and did some testing, it's ready for review

nmbryant avatar Jan 10 '22 18:01 nmbryant

Unit Test Results (build & test)

  8 files    8 suites   16s :stopwatch: 73 tests 73 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 72d6e139.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Feb 02 '22 04:02 github-actions[bot]

@nmbryant Hi!

I know there's been some time since there was last activity on this PR!

If you're still interested and willing to make these changes, we'll need to update to get the more recent changes. There should be some improvements that will make this PR much easier.

Otherwise, we will look at taking this over. Apologies for the delay on our side.

John

jjoyce0510 avatar Jun 06 '22 16:06 jjoyce0510

Closing this PR due to inactivity. @nmbryant if you'd like to open this up again, please let us know!

aditya-radhakrishnan avatar Oct 25 '22 20:10 aditya-radhakrishnan