datahub icon indicating copy to clipboard operation
datahub copied to clipboard

assigment property on front-end module

Open RafaelFranciscoLuqueCerezo opened this issue 6 months ago • 5 comments

fix: parsing needed property on frontend module for oauth authentication

As it was commeted on the pr: https://github.com/datahub-project/datahub/pull/13667 Right now we are stuck due to this error, that's why, even though it was mentioned that a refactor was going to be done to solve this problem, I wonder if this PR can be applied to get us unstuck.

we have found a problem trying to configure OAUTH on kafka on the frontend project , we have this error on logs: image

As you can see despite we have previously configured correctly the oauth bearer token endpoint , this configuration is not properly applied , it appears as null: image

Our configuration is:

springKafkaConfigurationOverrides: security.protocol: SASL_SSL sasl.mechanism: OAUTHBEARER sasl.login.callback.handler.class: org.apache.kafka.common.security.oauthbearer.OAuthBearerLoginCallbackHandler sasl.oauthbearer.token.endpoint.url: https://login.microsoftonline.com/xxxxxx/oauth2/v2.0/token sasl.oauthbearer.method: oidc

We think maybe it is necessary to set the assignment of this property on these files:

datahub-frontend/app/client/KafkaTrackingProducer.java datahub-frontend/conf/application.conf

Copyright 2025 Santander Global Tech & Operations All rights reserved.

Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

The plan in that PR #13667 is slightly modified. The plan will actually be to remove the kafka producer from the datahub-frontend component entirely. The tracking calls will be delegated to GMS which allows us to remove duplicated configuration.

david-leifker avatar Jun 10 '25 14:06 david-leifker

This PR has a compilation issue which would block merging.

Error:  /home/runner/work/datahub/datahub/datahub-frontend/app/client/KafkaTrackingProducer.java:157:  error: cannot find symbol

david-leifker avatar Jun 10 '25 14:06 david-leifker

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...hub-frontend/app/client/KafkaTrackingProducer.java 0.00% 1 Missing :warning:

:x: Your patch check has failed because the patch coverage (0.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

:loudspeaker: Thoughts on this report? Let us know!

codecov[bot] avatar Jun 12 '25 08:06 codecov[bot]

This PR has a compilation issue which would block merging.

Error:  /home/runner/work/datahub/datahub/datahub-frontend/app/client/KafkaTrackingProducer.java:157:  error: cannot find symbol

It seems to be resolved after last commit, right? @david-leifker . Thanks for your previous comment

Pulled your changes in to another PR with similar changes, this will hopefully unblock you! https://github.com/datahub-project/datahub/pull/13767

david-leifker avatar Jun 13 '25 12:06 david-leifker

The kafka config is no longer required in datahub-frontend after this PR -- already merged. If that meets your need, this PR is no longer required.

chakru-r avatar Jul 23 '25 12:07 chakru-r