datahub icon indicating copy to clipboard operation
datahub copied to clipboard

feat(quickstart): migrate to compose profile and other improv.

Open chakru-r opened this issue 7 months ago • 3 comments

  • migrate quickstart to use docker-compose profile based files -- that are more frequently used during dev
  • Saves a fully rendered docker-compose file via docker compose config
  • Add disk space checks to pre-flight checks
  • Handle incompatiblities to datahub installed by earlier versions of CLI using the older compose files and provide migration paths
  • CI tests for
    • CLI functional tests and for migration from datahub installed by earlier version of CLI
    • Detect if fully rendered compose file is stale after after build changes that cause changes
    • Run regular tests on previously released versions of datahub and head with latest quickstart CLI to ensure they continue to work (can fail due to external dependency changes)
  • Documentation updates

chakru-r avatar May 20 '25 15:05 chakru-r

Codecov Report

Attention: Patch coverage is 81.25000% with 21 lines in your changes missing coverage. Please review.

:x: Unsupported file format

Upload processing failed due to unsupported file format. Please review the parser error message:
Error parsing JUnit XML in /home/runner/work/datahub/datahub/metadata-io/build/test-results/test/TEST-com.linkedin.metadata.graph.search.elasticsearch.SearchGraphServiceElasticSearchTest.xml at 681:1058

Caused by: RuntimeError: Error converting computed name to ValidatedString

Caused by:
    string is too long</code></pre>

For more help, visit our troubleshooting guide.

Files with missing lines Patch % Lines
metadata-ingestion/src/datahub/cli/docker_cli.py 56.09% 18 Missing :warning:
metadata-ingestion/src/datahub/cli/docker_check.py 96.15% 2 Missing :warning:
...ingestion/src/datahub/cli/quickstart_versioning.py 94.73% 1 Missing :warning:

:loudspeaker: Thoughts on this report? Let us know!

codecov[bot] avatar May 20 '25 15:05 codecov[bot]

🔴 Meticulous spotted visual differences in 3 of 1294 screens tested: view and approve differences detected.

Meticulous evaluated ~8 hours of user flows against your PR.

Last updated for commit 76318ff. This comment will update as new commits are pushed.

alwaysmeticulous[bot] avatar Jun 03 '25 11:06 alwaysmeticulous[bot]

Bundle Report

Changes will decrease total bundle size by 27.23kB (-0.14%) :arrow_down:. This is within the configured threshold :white_check_mark:

Detailed changes
Bundle name Size Change
datahub-react-web-esm 19.66MB -27.23kB (-0.14%) :arrow_down:

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js -27.23kB 16.04MB -0.17%

codecov[bot] avatar Jun 03 '25 11:06 codecov[bot]