[v1.0-rc/bug] Business Attributes are not available in the new UI

[Masterchen09]

Describe the bug Same as for the other bugreport I just opened...usually I would fix it myself, but I currently do not have the time for it, therefore only a bugreport...

The business attributes are currently not "accessible" in the new UI - technically you can access them by manually creating the link...but there is currently no link available...

It seems the business attributes UI is working fine in the new UI if you access it directly (yourdomain.com/business-attribute), but it seems the corresponding entry was forgotten here...

https://github.com/datahub-project/datahub/blob/6097820c81764835b3909bdb98acc0f70af3fd74/datahub-web-react/src/app/homeV2/layout/navBarRedesign/NavSidebar.tsx

While the link is available in the V1 UI via the header:

https://github.com/datahub-project/datahub/blob/6097820c81764835b3909bdb98acc0f70af3fd74/datahub-web-react/src/app/shared/admin/HeaderLinks.tsx

To Reproduce See above.

Expected behavior n/a

Screenshots and/or Screen Recordings n/a

System details (please complete the following information):

• v1.0-rc2

edit: 1.0-rc3 is also affected

Additional context n/a

[deepgarg760]

@Masterchen09 Business Attribute is configured behind the feature flag: https://github.com/datahub-project/datahub/blob/v1.0.0rc1/metadata-service/configuration/src/main/resources/application.yaml#L486

I haven't tried the new UI as of now but I guess, once its enable, business attribute link would be visible

[Masterchen09]

@deepgarg-visa Of course the feature flag for the business attributes is enabled. With the old UI the link to the business attributes is visible in the header menu, only the V2 UI is missing such a link, see also here: https://github.com/datahub-project/datahub/blob/6097820c81764835b3909bdb98acc0f70af3fd74/datahub-web-react/src/app/homeV2/layout/navBarRedesign/NavSidebar.tsx

Here is also a screenshot of the sidebar where I would expect the link to the business attributes...

Similar to the old UI in the header menu...

I have also noticed right now that the business attributes are also not visible in the sidebar when selecting a column:

Most likely it is missing because the business attributes are not part of DataHub Cloud and the new UI comes from there...

[deepgarg760]

@Masterchen09 then its concerning @david-leifker @chriscollins3456 could you please shed some light on this

[Masterchen09]

@deepgarg-visa @david-leifker @chriscollins3456 @maggiehays

Is there any update on this one? :-)

[david-leifker]

There are currently no plans to add business attributes to the new UI at the moment. We would accept a community contribution to add the feature to the new UI.

[chriscollins3456]

@Masterchen09 would you be able to list out the surface area of where all of the business attributes features missing in the V2 UI are? since this was a community led initiative we'd like to make sure we have all of the expected areas sized up before we commit to working on this. Thanks so much!

[Masterchen09]

@chriscollins3456 I am definitely not an expert regarding the business attributes, but here are my findings based on the original PR for the business attributes (https://github.com/datahub-project/datahub/pull/9863/files) and a comparison between the old and new UI:

• The UI where you create the business attributes (yourdomain.com/business-attribute) seems to be working fine with the new UI from a technical perspective, but of course it is using the old components and style (e.g. if you compare it to the UI of the structured properties). Additionally a menu link is missing (e.g. below the menu link of the structured properties).

• When a single business attribute is viewed as an entity (e.g. by clicking on it in the list with all business attributes or via the search) the glossary terms are missing in the sidebar:

Same for the sidebar when searching (I think it is technically the same sidebar which is shown when you view an entity):

Additionally the empty space below the entity seems to be wrong here (I think that's the place for the "matches XYZ" hints), it seems this is only the case for business attributes and not the other entities.

• When viewing a dataset, the business attributes are missing in the schema metadata table and the sidebar for a single column:

I am not sure whether I forgot any places where the business attributes are used - @deepgarg-visa in case I forgot something I guess you could complete the list as you have originally developed the business attributes. :-)

[mounicanaidu]

@chriscollins3456 any update on this?

[deepgarg760]

@mounicanaidu , We are under progress on this and PR has been raised Please refer https://github.com/datahub-project/datahub/pull/15452