datahub icon indicating copy to clipboard operation
datahub copied to clipboard

fix(ui): show DataHub logo for DataHub sources in ingestion souces list

Open Masterchen09 opened this issue 4 months ago • 0 comments

I saw in this PR (#11518) that for the datahub-gc source no platform logo is shown...we could show a DataHub Logo for all DataHub sources...;-)

SOURCE_TO_PLATFORM_URN and PLATFORM_URN_TO_LOGO are used by useGetSourceLogoUrl to return the logo URL: https://github.com/datahub-project/datahub/blob/6b09346ca554783906afd8901ba9f89e1ef7310d/datahub-web-react/src/app/ingest/source/builder/useGetSourceLogoUrl.ts#L9

The entry for vertica in SOURCE_TO_PLATFORM_URN is redundant and not needed, because the platform urn is already correct for vertica and has not be "translated"...

Checklist

  • [x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • [x] Links to related issues (if applicable)
  • [x] Tests for the changes have been added/updated (if applicable)
  • [x] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • [x] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Masterchen09 avatar Oct 17 '24 15:10 Masterchen09