datahub
datahub copied to clipboard
fix(ui): enable search for tag entity in advanced filters and views
Strange, but isSearchEnabled returns false for the Tag entity - in the normal search Tag is selectable (and searchable) as an entity, isSearchEnabled causes the Tag entity to be unavailable in the entity type selection in advanced filters and in the view definition...
edit:
I noticed some more issues in the same context: The text for the ER-Model-Relationships and Schema Fields was missing in the same filter dialog. Additionally the Business Attributes and ER-Model-Relationship were visible even if the feature flags were not active, because both entities were always added to the entity registry searchable independent from the value of the feature flags.
edit²:
And the entity types in the dropdown were not sorted...
edit³:
Some more dropdown boxes were not sorted and had some issues with the search function (i.e. only the technical id/name/value was searched, but not the visible text)...
Checklist
- [x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
- [x] Links to related issues (if applicable)
- [x] Tests for the changes have been added/updated (if applicable)
- [x] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
- [x] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub
Summary by CodeRabbit
Summary by CodeRabbit
-
New Features
- Enabled search functionality for tags, allowing users to search for tags within the application.
- Introduced conditional registration of entities based on feature flags, enhancing flexibility in entity management.
- Added filtering capabilities in dropdowns to improve option searchability for policy forms.
-
Improvements
- Updated collection and entity names for clarity and consistency, improving user understanding of entity purposes.
- Sorted entity types in the selection modal for a more user-friendly experience.
- Enhanced filtering and sorting functionalities for privilege options in policy forms.